follow up to PR#4406: read only from localParams and do not read mmAu…

[renatoh]

Since it does not look like we are moving forward with github.com//pull/4475, I have created this PR as a
follow up on the comments by @dsmiley on the already merged PR #4406

[dsmiley]

While I like the fix relating to minShouldMatch, as it's non-released... I'm hesitant to approve the clauses() as this is technically a change to existing behavior, even if I'm somewhat suspicious someone depends on this behavior. It's really unfortunate Solr doesn't have a consistent/unified approach to parameter resolution that all users can understand. Instead, each QP makes its own decision on how each param is resolved. :-(

[renatoh]

While I like the fix relating to minShouldMatch, as it's non-released... I'm hesitant to approve the clauses() as this is technically a change to existing behavior, even if I'm somewhat suspicious someone depends on this behavior. It's really unfortunate Solr doesn't have a consistent/unified approach to parameter resolution that all users can understand. Instead, each QP makes its own decision on how each param is resolved. :-(

I see you point. I changed it because what I got from one of your earlier comments is that BoolQParser should read only localParams, and not params. Such a change is only possible in a major version since it's technically breaking backward compatibility?

[dsmiley]

Right; we put backwards-compatibility high on our values in Solr. We do make exceptions, say a security matter. Or if maybe a change is judged very obscure.