Skip to content

chore(pyamber): remove dead duplicate TimedBuffer#5981

Open
Ma77Ball wants to merge 2 commits into
apache:mainfrom
Ma77Ball:chore/remove-dead-timed-buffer
Open

chore(pyamber): remove dead duplicate TimedBuffer#5981
Ma77Ball wants to merge 2 commits into
apache:mainfrom
Ma77Ball:chore/remove-dead-timed-buffer

Conversation

@Ma77Ball

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

  • Deleted amber/src/main/python/core/util/console_message/timed_buffer.py, a dead, unreferenced near-duplicate of the live core/util/buffer/timed_buffer.py.
  • No other files change: the only live TimedBuffer user, console_message_manager.py, already imports the buffer/ version, and the sibling files in the console_message/ directory (error_message, replace_print, timestamp) remain in use and are untouched.

Any related issues, documentation, discussions?

Closes: #5980

How was this PR tested?

  • Pure deletion of unreferenced code, so no test was added or changed. Confirmed dead three ways: grep -rn "console_message.timed_buffer" amber/src returns no importers, there is no __init__ re-export of the module, and no test references it.
  • Reviewer can verify with cd amber/src/main/python && grep -rn "console_message.timed_buffer\|console_message import timed_buffer" ., expect zero matches outside the deleted file itself.

Was this PR authored or co-authored using generative AI tooling?

Co-authored with Claude Opus 4.8 in compliance with ASF

no import of timed_buffer are found or used in Texera
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@codecov-commenter

codecov-commenter commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.62%. Comparing base (24b587f) to head (7ceeeee).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5981      +/-   ##
============================================
- Coverage     56.89%   56.62%   -0.27%     
+ Complexity     3058     3040      -18     
============================================
  Files          1129     1129              
  Lines         43802    43802              
  Branches       4743     4743              
============================================
- Hits          24922    24804     -118     
- Misses        17449    17548      +99     
- Partials       1431     1450      +19     
Flag Coverage Δ *Carryforward flag
access-control-service 70.00% <ø> (ø) Carriedforward from 3d7486b
agent-service 44.59% <ø> (ø) Carriedforward from 3d7486b
amber 58.00% <ø> (-0.66%) ⬇️ Carriedforward from 3d7486b
computing-unit-managing-service 0.00% <ø> (ø) Carriedforward from 3d7486b
config-service 52.30% <ø> (ø) Carriedforward from 3d7486b
file-service 62.81% <ø> (ø) Carriedforward from 3d7486b
frontend 50.09% <ø> (-0.04%) ⬇️ Carriedforward from 3d7486b
notebook-migration-service 78.57% <ø> (ø) Carriedforward from 3d7486b
pyamber 91.10% <ø> (-0.05%) ⬇️
python 90.69% <ø> (ø) Carriedforward from 3d7486b
workflow-compiling-service 55.14% <ø> (ø) Carriedforward from 3d7486b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

✅ No material benchmark regressions detected

🟢 4 better · 🔴 0 worse · ⚪ 11 noise (<±5%) · 0 without baseline

Compared against main 24b587f benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🟢 bs=10 sw=10 sl=64 457 0.279 21,925/27,187/27,187 us 🟢 -5.1% / 🔴 +77.9%
🟢 bs=100 sw=10 sl=64 945 0.577 102,925/132,603/132,603 us 🟢 -6.5% / 🔴 +22.3%
bs=1000 sw=10 sl=64 1,128 0.688 886,470/941,537/941,537 us ⚪ within ±5% / 🟢 -12.0%
Baseline details

Latest main 24b587f from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 457 tuples/sec 457 tuples/sec 770.95 tuples/sec 0.0% -40.7%
bs=10 sw=10 sl=64 MB/s 0.279 MB/s 0.279 MB/s 0.471 MB/s 0.0% -40.7%
bs=10 sw=10 sl=64 p50 21,925 us 21,666 us 12,775 us +1.2% +71.6%
bs=10 sw=10 sl=64 p95 27,187 us 28,662 us 15,286 us -5.1% +77.9%
bs=10 sw=10 sl=64 p99 27,187 us 28,662 us 18,795 us -5.1% +44.7%
bs=100 sw=10 sl=64 throughput 945 tuples/sec 947 tuples/sec 976.93 tuples/sec -0.2% -3.3%
bs=100 sw=10 sl=64 MB/s 0.577 MB/s 0.578 MB/s 0.596 MB/s -0.2% -3.2%
bs=100 sw=10 sl=64 p50 102,925 us 99,681 us 102,557 us +3.3% +0.4%
bs=100 sw=10 sl=64 p95 132,603 us 141,768 us 108,383 us -6.5% +22.3%
bs=100 sw=10 sl=64 p99 132,603 us 141,768 us 115,249 us -6.5% +15.1%
bs=1000 sw=10 sl=64 throughput 1,128 tuples/sec 1,127 tuples/sec 1,009 tuples/sec +0.1% +11.8%
bs=1000 sw=10 sl=64 MB/s 0.688 MB/s 0.688 MB/s 0.616 MB/s 0.0% +11.7%
bs=1000 sw=10 sl=64 p50 886,470 us 883,386 us 997,695 us +0.3% -11.1%
bs=1000 sw=10 sl=64 p95 941,537 us 926,248 us 1,036,731 us +1.7% -9.2%
bs=1000 sw=10 sl=64 p99 941,537 us 926,248 us 1,069,334 us +1.7% -12.0%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,437.27,200,128000,457,0.279,21925.13,27187.10,27187.10
1,100,10,64,20,2115.75,2000,1280000,945,0.577,102924.56,132602.58,132602.58
2,1000,10,64,20,17735.41,20000,12800000,1128,0.688,886470.11,941537.41,941537.41

@Ma77Ball Ma77Ball changed the title chore(pyamber): remove dead duplicate TimedBuffer (draft) chore(pyamber): remove dead duplicate TimedBuffer Jun 28, 2026
@Ma77Ball Ma77Ball marked this pull request as draft June 28, 2026 19:23
@Ma77Ball Ma77Ball changed the title (draft) chore(pyamber): remove dead duplicate TimedBuffer chore(pyamber): remove dead duplicate TimedBuffer Jun 28, 2026
@Ma77Ball Ma77Ball marked this pull request as ready for review July 1, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead duplicate TimedBuffer in pyamber

2 participants