chore(pyamber): remove dead duplicate TimedBuffer#5981
Open
Ma77Ball wants to merge 2 commits into
Open
Conversation
no import of timed_buffer are found or used in Texera
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5981 +/- ##
============================================
- Coverage 56.89% 56.62% -0.27%
+ Complexity 3058 3040 -18
============================================
Files 1129 1129
Lines 43802 43802
Branches 4743 4743
============================================
- Hits 24922 24804 -118
- Misses 17449 17548 +99
- Partials 1431 1450 +19
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
✅ No material benchmark regressions detected🟢 4 better · 🔴 0 worse · ⚪ 11 noise (<±5%) · 0 without baseline
Baseline detailsLatest main
Raw CSVconfig_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,437.27,200,128000,457,0.279,21925.13,27187.10,27187.10
1,100,10,64,20,2115.75,2000,1280000,945,0.577,102924.56,132602.58,132602.58
2,1000,10,64,20,17735.41,20000,12800000,1128,0.688,886470.11,941537.41,941537.41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
amber/src/main/python/core/util/console_message/timed_buffer.py, a dead, unreferenced near-duplicate of the livecore/util/buffer/timed_buffer.py.TimedBufferuser,console_message_manager.py, already imports thebuffer/version, and the sibling files in theconsole_message/directory (error_message,replace_print,timestamp) remain in use and are untouched.Any related issues, documentation, discussions?
Closes: #5980
How was this PR tested?
grep -rn "console_message.timed_buffer" amber/srcreturns no importers, there is no__init__re-export of the module, and no test references it.cd amber/src/main/python && grep -rn "console_message.timed_buffer\|console_message import timed_buffer" ., expect zero matches outside the deleted file itself.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF