fix(frontend): keep admin page height consistent#6035
Conversation
|
👋 Thanks for your first contribution to Texera, @Amer-Mukhtar! If you're looking for a good place to start, browse issues labeled You can drive common housekeeping yourself by commenting one of these commands on its own line:
Each command must match exactly: |
Automated Reviewer SuggestionsBased on the
|
|
Hi @kz930, please review this when you have time. It’s a quick fix to stop the admin page layouts from shifting. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6035 +/- ##
============================================
- Coverage 56.90% 56.28% -0.62%
Complexity 3024 3024
============================================
Files 1129 1131 +2
Lines 43794 45713 +1919
Branches 4743 5195 +452
============================================
+ Hits 24920 25731 +811
- Misses 17399 18467 +1068
- Partials 1475 1515 +40
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/request-review @kz930 |
|
hmm, from screenshot, the before looks more consistent, the after ones are diff on height. did you put the images in a wrong order? |
|
especially the vertical space around the search bar, are not consistent? |
Yes, I thought I had corrected that, but the images were still in the wrong order. I’ve fixed it now. |
Yes, that’s the part that looks inconsistent. |
What changes were proposed in this PR?
The admin pages didn't all have the same height, so the layout shifted when switching between sections. This meant the buttons could move around and you'd have to move your cursor to click them.
The proposed change makes the admin pages keep a consistent height, so the layout stays put when moving between sections. It's a small CSS change to the shared dashboard content area.
The fix makes nz-content a bounded flex scroll container, so overflowing content scrolls inside the content area while the sidebar and top nav stay fixed and the page height stays consistent across all admin pages. The nz-content rule now adds min-height: 0 and flex: 1 alongside the existing overflow-y: auto.
Any related issues, documentation, discussions?
Closes #3588
How was this PR tested?
Tested manually
Was this PR authored or co-authored using generative AI tooling?
Nope.