Skip to content

fix(frontend): keep admin page height consistent#6035

Open
Amer-Mukhtar wants to merge 3 commits into
apache:mainfrom
Amer-Mukhtar:fix/admin-page-height
Open

fix(frontend): keep admin page height consistent#6035
Amer-Mukhtar wants to merge 3 commits into
apache:mainfrom
Amer-Mukhtar:fix/admin-page-height

Conversation

@Amer-Mukhtar

@Amer-Mukhtar Amer-Mukhtar commented Jun 30, 2026

Copy link
Copy Markdown

What changes were proposed in this PR?

The admin pages didn't all have the same height, so the layout shifted when switching between sections. This meant the buttons could move around and you'd have to move your cursor to click them.

The proposed change makes the admin pages keep a consistent height, so the layout stays put when moving between sections. It's a small CSS change to the shared dashboard content area.

The fix makes nz-content a bounded flex scroll container, so overflowing content scrolls inside the content area while the sidebar and top nav stay fixed and the page height stays consistent across all admin pages. The nz-content rule now adds min-height: 0 and flex: 1 alongside the existing overflow-y: auto.

After Before

Any related issues, documentation, discussions?

Closes #3588

How was this PR tested?

Tested manually

  1. Opened each admin page (Users, Executions, Gmail, Settings) and confirmed the page height and the top nav and search bar no longer shift between sections.
  2. Verified the Users page with both few and many rows: content now scrolls within the content area instead of growing the whole page.
  3. Checked other dashboard pages (Workflows, Datasets) to confirm no scrolling regressions from the shared nz-content change.

Was this PR authored or co-authored using generative AI tooling?

Nope.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your first contribution to Texera, @Amer-Mukhtar!

If you're looking for a good place to start, browse issues labeled starter-task; they're scoped to be approachable for newcomers.

You can drive common housekeeping yourself by commenting one of these commands on its own line:

  • Issues. Comment /take to assign an open issue to yourself, or /untake to release it. You can find unclaimed work with the search filter is:issue is:open no:assignee.
  • Sub-issues. To link issues into a parent/child hierarchy, comment /sub-issue #5166 #5222 on the parent to attach those children (or /unsub-issue #5166 #5222 to detach them). From a child issue, comment /parent-issue #5166 to set its parent, or /unparent-issue to clear it (the current parent is detected automatically). References may be written as #5166 or as a bare 5166; cross-repository references are not supported.
  • Pull requests (author only). Comment /request-review @user to request a review from someone, or /unrequest-review @user to withdraw that request.

Each command must match exactly: /take this will not work, only /take does. For the full contribution flow, see CONTRIBUTING.md.

@github-actions github-actions Bot added fix frontend Changes related to the frontend GUI labels Jun 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @kz930
    You can notify them by mentioning @kz930 in a comment.

@Amer-Mukhtar Amer-Mukhtar marked this pull request as ready for review June 30, 2026 09:48
@Amer-Mukhtar

Copy link
Copy Markdown
Author

Hi @kz930, please review this when you have time. It’s a quick fix to stop the admin page layouts from shifting.

@Yicong-Huang Yicong-Huang changed the title fix(frontend): keep admin page height consistent (Closes #3588) fix(frontend): keep admin page height consistent Jun 30, 2026
@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.28%. Comparing base (104bcc4) to head (ad5294e).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6035      +/-   ##
============================================
- Coverage     56.90%   56.28%   -0.62%     
  Complexity     3024     3024              
============================================
  Files          1129     1131       +2     
  Lines         43794    45713    +1919     
  Branches       4743     5195     +452     
============================================
+ Hits          24920    25731     +811     
- Misses        17399    18467    +1068     
- Partials       1475     1515      +40     
Flag Coverage Δ *Carryforward flag
access-control-service 70.00% <ø> (ø) Carriedforward from 104bcc4
agent-service 44.59% <ø> (ø) Carriedforward from 104bcc4
amber 58.75% <ø> (ø) Carriedforward from 104bcc4
computing-unit-managing-service 0.00% <ø> (ø) Carriedforward from 104bcc4
config-service 52.30% <ø> (ø) Carriedforward from 104bcc4
file-service 62.81% <ø> (ø) Carriedforward from 104bcc4
frontend 49.18% <ø> (-0.89%) ⬇️
notebook-migration-service 78.57% <ø> (ø) Carriedforward from 104bcc4
pyamber 90.20% <ø> (ø) Carriedforward from 104bcc4
python 90.76% <ø> (ø) Carriedforward from 104bcc4
workflow-compiling-service 55.14% <ø> (ø) Carriedforward from 104bcc4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Amer-Mukhtar

Copy link
Copy Markdown
Author

/request-review @kz930

@Yicong-Huang

Copy link
Copy Markdown
Contributor

hmm, from screenshot, the before looks more consistent, the after ones are diff on height. did you put the images in a wrong order?

@Yicong-Huang

Copy link
Copy Markdown
Contributor

especially the vertical space around the search bar, are not consistent?

@xuang7 xuang7 added the release/v1.2 back porting to release/v1.2 label Jun 30, 2026
@Amer-Mukhtar

Copy link
Copy Markdown
Author

hmm, from screenshot, the before looks more consistent, the after ones are diff on height. did you put the images in a wrong order?

Yes, I thought I had corrected that, but the images were still in the wrong order. I’ve fixed it now.

@Amer-Mukhtar

Copy link
Copy Markdown
Author

especially the vertical space around the search bar, are not consistent?

Yes, that’s the part that looks inconsistent.

@chenlica

chenlica commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@kz930 Please review it. After that, @mengw15 can review and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix frontend Changes related to the frontend GUI release/v1.2 back porting to release/v1.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the page height of the Admin Page

5 participants