-
Notifications
You must be signed in to change notification settings - Fork 168
test(workflow-operator): add unit test coverage for interval-join, and sleep #6098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+92
−0
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
1644a5b
test(workflow-operator): add unit test coverage for interval-join, sl…
aglinxinyuan 06d65cc
test(workflow-operator): address review on interval-join and sleep ex…
aglinxinyuan 19d4967
test(workflow-operator): drop CacheSourceOpExec spec (dead code since…
aglinxinyuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
...flow-operator/src/test/scala/org/apache/texera/amber/operator/sleep/SleepOpExecSpec.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.texera.amber.operator.sleep | ||
|
|
||
| import org.apache.texera.amber.core.tuple.{Attribute, AttributeType, Schema, Tuple} | ||
| import org.apache.texera.amber.util.JSONUtils.objectMapper | ||
| import org.scalatest.flatspec.AnyFlatSpec | ||
|
|
||
| class SleepOpExecSpec extends AnyFlatSpec { | ||
|
|
||
| private val schema: Schema = Schema().add(new Attribute("v", AttributeType.INTEGER)) | ||
|
|
||
| private def tuple(v: Int): Tuple = | ||
| Tuple.builder(schema).add(new Attribute("v", AttributeType.INTEGER), Integer.valueOf(v)).build() | ||
|
|
||
| // SleepOpDesc is a LogicalOp: serialize a real instance so the polymorphic operatorType | ||
| // discriminator is present (a hand-written JSON string would fail to deserialize). | ||
| private def descString(sleepTime: Int): String = { | ||
| val desc = new SleepOpDesc() | ||
| desc.sleepTime = sleepTime | ||
| objectMapper.writeValueAsString(desc) | ||
| } | ||
|
|
||
| "SleepOpExec" should "construct from a serialized SleepOpDesc" in { | ||
| val exec = new SleepOpExec(descString(0)) | ||
| assert(exec != null) | ||
| } | ||
|
|
||
| "SleepOpExec.processTuple" should "return the input tuple unchanged" in { | ||
| // sleepTime = 0 -> Thread.sleep(0), instant | ||
| val exec = new SleepOpExec(descString(0)) | ||
| val emitted = exec.processTuple(tuple(7), 0).toList | ||
| assert(emitted.map(_.asInstanceOf[Tuple]) == List(tuple(7))) | ||
| } | ||
|
aglinxinyuan marked this conversation as resolved.
Outdated
|
||
|
|
||
| it should "emit exactly one tuple per input" in { | ||
| val exec = new SleepOpExec(descString(0)) | ||
| val emitted = (0 until 5).flatMap(i => exec.processTuple(tuple(i), 0).toList) | ||
| assert(emitted.map(_.asInstanceOf[Tuple]) == (0 until 5).map(tuple).toList) | ||
|
aglinxinyuan marked this conversation as resolved.
Outdated
|
||
| } | ||
| } | ||
63 changes: 63 additions & 0 deletions
63
.../src/test/scala/org/apache/texera/amber/operator/source/cache/CacheSourceOpExecSpec.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.texera.amber.operator.source.cache | ||
|
|
||
| import org.apache.texera.amber.core.storage.VFSURIFactory | ||
| import org.apache.texera.amber.core.virtualidentity.{ | ||
| ExecutionIdentity, | ||
| OperatorIdentity, | ||
| PhysicalOpIdentity, | ||
| WorkflowIdentity | ||
| } | ||
| import org.apache.texera.amber.core.workflow.{GlobalPortIdentity, PortIdentity} | ||
| import org.scalatest.flatspec.AnyFlatSpec | ||
| import org.scalatest.matchers.should.Matchers | ||
|
|
||
| import java.net.URI | ||
|
|
||
| /** | ||
| * Unit tests for the in-memory validation in [[CacheSourceOpExec]]'s constructor. The | ||
| * result-storage read path requires a live Iceberg catalog and is covered by the amber | ||
| * integration suite, not here. | ||
| */ | ||
| class CacheSourceOpExecSpec extends AnyFlatSpec with Matchers { | ||
|
|
||
| private val globalPortId = | ||
| GlobalPortIdentity( | ||
| PhysicalOpIdentity(OperatorIdentity("opA"), "main"), | ||
| PortIdentity(0), | ||
| input = true | ||
| ) | ||
|
|
||
| "CacheSourceOpExec" should "reject a storage URI whose resource type is not RESULT" in { | ||
| val stateUri = | ||
| VFSURIFactory.stateURI( | ||
| VFSURIFactory.createPortBaseURI(WorkflowIdentity(7L), ExecutionIdentity(11L), globalPortId) | ||
| ) | ||
| val ex = intercept[RuntimeException](new CacheSourceOpExec(stateUri)) | ||
| ex.getMessage shouldBe "The storage URI must point to a result storage" | ||
| } | ||
|
|
||
| it should "reject a non-vfs storage URI" in { | ||
| intercept[IllegalArgumentException]( | ||
| new CacheSourceOpExec(new URI("http:///wid/1/eid/1/result")) | ||
| ) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.