fix(filters): add aria heading roles to sort and filter section labels#167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
Improve accessibility of the date filter dropdown by correctly marking section labels as ARIA headings.
📌 Summary
The "Sort By" and "Filter by" labels inside
DateFilterDropdownwere rendered as<li>elements with no ARIA role, making them invisible as structural headings to screen readers. This PR addsrole="heading"andaria-level={3}to both labels so assistive technologies can announce them as section headings.🔧 Changes Implemented
role="heading" aria-level={3}to the "Sort By" section labelrole="heading" aria-level={3}to the "Filter by" section label🛠️ How It Works?
Typographycomponents inside the dropdown menu are rendered as<li>elements (viacomponent="li"), which doesn't carry implicit heading semantics.role="heading"overrides the listitem role for screen readers, andaria-level={3}communicates the correct heading hierarchy.✅ Checklist Before Merging
📸 Screenshots (if applicable)
N/A — no visual changes.
🔗 Related Issues
https://projects.arbisoft.com/arbisoft/browse/ASP-167/
📢 Notes for Reviewers
The only change is two added ARIA attributes on
Typographynodes that serve as section separators inside the MUI Menu. Therole="presentation"already on theDivideris unaffected. Reviewers may want to spot-check with a browser accessibility tree inspector (e.g. Chrome DevTools → Accessibility panel) to confirm heading levels look correct in context.