avr: platform.txt: sketch_flags, -DPLATFORM={version}

[phd]

platform.txt:

• sketch_flags for use with ./platform.sketch.txt
• define -DPLATFORM= with platform {version}
• added -DARDUINO_ARCH= and -DARDUINO_BOARD=

See: arduino/arduino-builder#282

[matthijskooijman]

I'm not so sure about the sketch_flags stuff (and I expect it might raise more discussion, as it ties in with previous discussion about setting sketch-specific options that has of yet been unresolved).

However, adding a PLATFORM version define sounds like a sane thing to do. Especially since the IDE and core versions are no longer tied together since quite some time, checking ARDUINO is no longer effective to check for the presence of certain features of bugfixes in the core.

Adding ARDUINO_BOARD and ARDUINO_ARCH is probably a good idea, though I wonder if that stuff should really be done in arduino-builder with some "default flags" thing (in which case the ARDUINO define and some others should be moved as well), to get some consistency in different cores...

[matthijskooijman]

What is the purpose of this variable? It seems unused?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}