Skip to content

TypeChecker: skip external free functions in using for resolution #16719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
genisis0x wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

TypeChecker: skip external free functions in using for resolution #16719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions libsolidity/analysis/TypeChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4052,6 +4052,20 @@ void TypeChecker::endVisit(UsingForDirective const& _usingFor)
FunctionDefinition const& functionDefinition =
dynamic_cast<FunctionDefinition const&>(*path->annotation().referencedDeclaration);

// Free functions with an explicit visibility were already flagged by the
// SyntaxChecker (error 4126). That error is not fatal, so resolution
// continues into this directive and calls `functionDefinition.type()`,
// which asserts non-external. Skip the entry to avoid the ICE; the user
// will still see the visibility error from the function definition.
if (
!functionDefinition.libraryFunction() &&
functionDefinition.visibility() == Visibility::External
)
{
solAssert(m_errorReporter.hasErrors());
continue;
}

FunctionType const* functionType = dynamic_cast<FunctionType const*>(
functionDefinition.libraryFunction() ?
functionDefinition.typeViaContractName() :
Expand Down
7 changes: 7 additions & 0 deletions test/libsolidity/syntaxTests/using/external_free_function.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Used to cause ICE in FunctionDefinition::type() when an external free
// function (already a syntax error) was bound via `using for`.
function f(int) external;
using {f} for int global;
// ----
// SyntaxError 4126: (0-26): Free functions cannot have visibility.
// TypeError 4668: (0-26): Free functions must be implemented.