feat: add internal spec for debug-info#16780
Open
djolertrk wants to merge 17 commits into
Open
Conversation
Contributor
Author
| using ConstPtr = std::shared_ptr<SemanticDebugData const>; | ||
|
|
||
| std::optional<int64_t> lexicalScopeID; | ||
| std::vector<SemanticDebugVariable> variableDefinitions; |
Contributor
There was a problem hiding this comment.
Suggested change
| std::vector<SemanticDebugVariable> variableDefinitions; | |
| std::vector<SemanticDebugVariable> variableDefinitions = {}; |
Since you're using named initializers, this should fix the build.
Contributor
Author
|
@nikola-matic I fixed the build and here is the Thank you! |
9101b5d to
033cc91
Compare
9fd16e7 to
d08f715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the compiler-side model for carrying Solidity semantic debug info through the Yul pipeline, including AST-ID based reattachment across Yul reparse.
Current scope is intentionally narrow and we will add more entries into it once we are okay with the proposal on a high-level.
See
docs/internals/ethdebug_internal_metadata.rstfor more detailed explanation of the design.