Fix shadowing warning (2519) to cover inherited state variables

libsolidity/interface/CompilerStack.cpp

@@ -504,8 +504,6 @@ bool CompilerStack::analyze()
 			if (source->ast && !resolver.performImports(*source->ast, sourceUnitsByName))
 				return false;
 
-		resolver.warnHomonymDeclarations();
-
 		{
 			DocStringTagParser docStringTagParser(m_errorReporter);
 			for (Source const* source: m_sourceOrder)
@@ -518,6 +516,8 @@ bool CompilerStack::analyze()
 			if (source->ast && !resolver.resolveNamesAndTypes(*source->ast))
 				return false;
 
+		resolver.warnHomonymDeclarations();
+
 		if (experimentalSolidity)
 		{
 			if (!analyzeExperimental())

test/libsolidity/syntaxTests/scoping/name_shadowing_abstract_base_inherited_state_variable.sol

@@ -0,0 +1,11 @@
+abstract contract Base {
+    uint256 value = 10;
+}
+contract Child is Base {
+    function f() public pure returns (uint256) {
+        uint256 value = 99;
+        return value;
+    }
+}
+// ---- 
+// Warning 2519: (133-146): This declaration shadows an existing declaration.

test/libsolidity/syntaxTests/scoping/name_shadowing_function_parameter_vs_inherited_state_variable.sol

@@ -0,0 +1,10 @@
+contract Base {
+    uint256 value = 10;
+}
+contract Child is Base {
+    function f(uint256 value) public pure returns (uint256) {
+        return value;
+    }
+}
+// ----
+// Warning 2519: (82-95): This declaration shadows an existing declaration.

test/libsolidity/syntaxTests/scoping/name_shadowing_local_variable_vs_inherited_state_variable.sol

@@ -0,0 +1,11 @@
+contract Base {
+    uint256 value = 10;
+}
+contract Child is Base {
+    function f() public pure returns (uint256) {
+        uint256 value = 99;
+        return value;
+    }
+}
+// ----
+// Warning 2519: (124-137): This declaration shadows an existing declaration.

test/libsolidity/syntaxTests/scoping/name_shadowing_named_return_vs_inherited_state_variable.sol

@@ -0,0 +1,10 @@
+contract Base {
+    uint256 value = 10;
+}
+contract Child is Base {
+    function f() public pure returns (uint256 value) {
+        return 42;
+    }
+}
+// ----
+// Warning 2519: (105-118): This declaration shadows an existing declaration.

test/libsolidity/syntaxTests/scoping/name_shadowing_transitive_inheritance.sol

@@ -0,0 +1,12 @@
+contract A {
+    uint256 value = 10;
+}
+contract B is A {}
+contract C is B {
+    function f() public pure returns (uint256) {
+        uint256 value = 99;
+        return value;
+    }
+}
+// ----
+// Warning 2519: (133-146): This declaration shadows an existing declaration.