[v2] Add Session IDs to User-Agent header even when cache does not exist#10398
Open
aemous wants to merge 6 commits into
Open
[v2] Add Session IDs to User-Agent header even when cache does not exist#10398aemous wants to merge 6 commits into
aemous wants to merge 6 commits into
Conversation
AndrewAsseily
requested changes
Jun 17, 2026
…/3.12.6 Darwin/25.5.0 source/arm64, and modify code so that the test passes.
… snapshot of the header value at client creation time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
CLISessionDatabaseConnectionto allow a cache directory override to be passed in during initialization. This improves testability.Description of tests:
Manual test workflow
~/.aws/cli/cache:rm -rf ~/.aws/cli/cache.python3 -m awscli s3api list-buckets --debug 2> debug.txt.debug.txtand confirmed theUser-AgentHTTP header does not contain a session ID:aws-cli/2.35.2 md/awscrt#0.32.2 ua/2.1 os/macos#25.5.0 md/arch#arm64 lang/python#3.12.6 md/pyimpl#CPython m/c,E,C,a,n cfg/retry-mode#standard md/installer#source md/prompt#off md/command#s3api.list-buckets.~/.aws/cli/cache:rm -rf ~/.aws/cli/cache.python3 -m awscli s3api list-buckets --debug 2> debug.txt.debug.txtand confirmed theUser-AgentHTTP header contains a session ID:aws-cli/2.35.2 md/awscrt#0.32.2 ua/2.1 os/macos#25.5.0 md/arch#arm64 lang/python#3.12.6 md/pyimpl#CPython m/n,C,E,c,a cfg/retry-mode#standard md/installer#source sid/b871d801befe md/prompt#off md/command#s3api.list-bucketsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.