Fix NameError in ParamUnknownKeyError formatting#10406
Merged
Merged
Conversation
This commit fixes a typo in awscli/argprocess.py where valid_key was used instead of valid_keys, causing a NameError instead of displaying the intended shorthand parsing error. Fixes aws#10405
ashovlin
approved these changes
Jun 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10406 +/- ##
===========================================
+ Coverage 93.42% 93.61% +0.18%
===========================================
Files 211 211
Lines 17312 17358 +46
===========================================
+ Hits 16174 16249 +75
+ Misses 1138 1109 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks for the contribution! It should go out in the next release. The |
Member
|
This shipped in 1.45.34 today, thanks again @Dreamstick9 |
Contributor
Author
|
Happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a typo in
awscli/argprocess.pywhere aNameErrorwas raised during shorthand parsing errors becausevalid_keywas used instead ofvalid_keys.Fixes #10405
Testing Done:
ParamUnknownKeyErrornow successfully formats the error string instead of crashing with aNameError.