Skip to content

Add lock input feedback #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FilipHarald wants to merge 3 commits into
base: quattro
Choose a base branch
from
+30 −2
Open

Add lock input feedback #6137

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8d8a9c
Add lock input feedback
FilipHarald Jun 25, 2026
39708e7
Merge branch 'quattro' of https://github.com/basecamp/omarchy into fi…
FilipHarald Jun 29, 2026
aed0bb6
Respect themed lock border widths during pulse
FilipHarald Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions shell/plugins/lock/LockView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Item {
property bool loadBackground: true
property string passwordText: ""
property bool syncingPasswordText: false
property real inputBorderPulseWidth: 0

readonly property string placeholderText: "Enter Password"
readonly property int fieldWidth: 381
Expand All @@ -29,6 +30,16 @@ Item {
readonly property var inputBorderSpec: errorState
? Border.surfaceSpec("lock", "border-error", Color.lock.borderError, root.outlineThickness, "border-alpha")
: Border.surfaceSpec("lock", "border-active", Color.lock.borderActive, root.outlineThickness, "border-alpha")
readonly property var pulsedInputBorderSpec: ({
color: root.inputBorderSpec.color,
gradient: root.inputBorderSpec.gradient,
widths: {
top: root.inputBorderSpec.widths.top + root.inputBorderPulseWidth,
right: root.inputBorderSpec.widths.right + root.inputBorderPulseWidth,
bottom: root.inputBorderSpec.widths.bottom + root.inputBorderPulseWidth,
left: root.inputBorderSpec.widths.left + root.inputBorderPulseWidth,
},
})

signal submitPassword(string password)
signal passwordTextEdited(string password)
Expand Down Expand Up @@ -59,7 +70,14 @@ Item {
syncingPasswordText = false
}

onPasswordTextChanged: syncPasswordText()
function pulseInputField() {
inputBorderPulse.restart()
}

onPasswordTextChanged: {
syncPasswordText()
if (passwordText.length > 0) pulseInputField()
}
onInputEnabledChanged: {
if (inputEnabled) Qt.callLater(forcePasswordFocus)
}
Expand Down Expand Up @@ -107,10 +125,20 @@ Item {
height: root.fieldHeight
anchors.centerIn: parent
color: Color.lock.background
borderSpec: root.inputBorderSpec
borderSpec: root.inputBorderPulseWidth > 0 && !root.errorState
? root.pulsedInputBorderSpec
: root.inputBorderSpec
radius: Style.cornerRadius
clip: true

SequentialAnimation {
id: inputBorderPulse
running: false

PropertyAnimation { target: root; property: "inputBorderPulseWidth"; to: 1.1; duration: 40; easing.type: Easing.OutCubic }
PropertyAnimation { target: root; property: "inputBorderPulseWidth"; to: 0; duration: 240; easing.type: Easing.OutCubic }
}

TextInput {
id: passwordInput
anchors.fill: parent
Expand Down