Added support for lazy loading#177
Conversation
If a media query contains comments, the busting process is currently cancelled with a "Cannot read property 'property' of undefined" error. For example: @media only screen and (min-device-pixel-ratio: 2) and (min-resolution: 2dppx) { /** Just a comment */ .large-image { background-image: url('assets/image1.jpg'); } }
Support both versions of including videos using standalone video tag and using video tag in combination with source tags. Option 1 <video><source src="video.mp4" type="video/mp4" /></video> Option 2 <video src="video.mp4"></video>
…h-comments-issue Fix CSS processing for media queries with comments
Support cache busting for video tag
…en_registering Use passed in grunt when registering
'cachbust' => 'cachebust'
Fix typo in Readme
Match all icon references
Support cache busting for meta tags
|
Thanks for the PR. I'll have a look at merging this later. FYI, the next version of the plugin (currently the beta version on npm) will remove the need for adding filters to allow this to happen. You can take a look at what's changed in #147 or by changing to that branch and reading the README |
benhoIIand
force-pushed
the
master
branch
2 times, most recently
from
403a891 to
9747968
Compare
|
I'm slightly confused — what exactly does it do? |
|
@ArmorDarks A lot of times we use lazyloading of images, some common approaches are like using lazy class or data-original. I added support so that we can cache bust these implementations as well. |
|
@bhaskarmelkani Ah, I see. So how exactly does it work? I can't check the code, probably because of rebasing whole PR has been messed up and it's hard to read changes now... So it just scans |
|
@ArmorDarks Yeah, but its been very long since I updated it. And it working perfectly fine some of my production systems. |
I think it would be wise to do so, otherwise it's very hard to review it.
I just wanted to know how exactly it finds which |
|
@ArmorDarks It looks like the whole implementation is changed now, the support for filters is removed. |
|
Yeap, as @HollandBen mentioned above. Though, I think general idea of this PR is great, since it's indeed would be cool if lazyloaded images would be cachebusted too. However, maybe we should add config to state |
|
Yeah makes sense, maybe I will update the new implementation |
7 participants
Adding support for lazy loading, this is already done in this fork of you branch.
I am using the same fork in lot may projects in production environments with and without lazy load.
Thought, to create a PR for it. :)