Skip to content

fix: default destination page to match source on import #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonypiper wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: default destination page to match source on import #4084

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aec109
fix: default destination page to match source on single page import
tonypiper Apr 11, 2026
874e6f9
fix: clamp default destination page to valid range
tonypiper Apr 11, 2026
c01c9e5
refactor: rename import page vars to sourcePage and sync destination
tonypiper Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion webui/src/ImportExport/Import/Page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,15 @@ export const ImportPageWizard = observer(function ImportPageWizard({
}
}, [snapshot.pages, snapshot.page, isSinglePage])

const { pageNumber, setPageNumber, changePage } = usePagePicker(pages.data.length, 1)
const {
pageNumber: importPageNumber,
setPageNumber: setImportPageNumber,
changePage: changeImportPage,
} = usePagePicker(pageCount, 1)

const defaultDestinationPage = isSinglePage ? (snapshot.oldPageNumber ?? 1) : importPageNumber
Comment thread
tonypiper marked this conversation as resolved.
Outdated
const { pageNumber, setPageNumber, changePage } = usePagePicker(pages.data.length, defaultDestinationPage)

Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
const setConnectionRemap2 = useCallback(
(fromId: string, toId: string) => {
setConnectionRemap((oldRemap) => ({
Expand Down
Loading