Skip to content

fix: default destination page to match source on import #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonypiper wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: default destination page to match source on import #4084

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aec109
fix: default destination page to match source on single page import
tonypiper Apr 11, 2026
874e6f9
fix: clamp default destination page to valid range
tonypiper Apr 11, 2026
c01c9e5
refactor: rename import page vars to sourcePage and sync destination
tonypiper Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion webui/src/ImportExport/Import/Page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,22 @@ export const ImportPageWizard = observer(function ImportPageWizard({
}
}, [snapshot.pages, snapshot.page, isSinglePage])

const { pageNumber, setPageNumber, changePage } = usePagePicker(pages.data.length, 1)
const {
pageNumber: importPageNumber,
setPageNumber: setImportPageNumber,
changePage: changeImportPage,
} = usePagePicker(pageCount, 1)

const defaultDestinationPage = useMemo(() => {
if (!isSinglePage) return importPageNumber
const oldPage = snapshot.oldPageNumber
if (typeof oldPage === 'number' && Number.isInteger(oldPage) && oldPage >= 1 && oldPage <= pages.data.length) {
return oldPage
}
return -1

@arikorn arikorn Apr 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion @tonypiper ! Some comments

  1. This will default to a new page (-1) rather than the first page (1), as was the pre-existing behavior. Is that your intention? This actually makes sense when oldPage is beyond pages.data.length, but otherwise it should probably default to 1.
  2. useMemo here seems a bit of overkill: you're just doing a couple of logical tests and all it's doing is setting a default, so it's a no-op if any of the dependents change, anyway. Suggestion: either it should be done only on mount or just take it out of a useMemo.
  3. Technically the !isSinglePage test isn't necessary, since full won't have an oldPageNumber, and really, if there is an oldPageNumber it should probably be used.

@tonypiper tonypiper Apr 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick and helpful feedback. Defaulting to a new page was intentional - original motivation was that I have important buttons on page 1 and they kept getting overwritten. It seems to me that it's safer to create a new page (and then move it manually if need be) than overwrite an existing page if we can't be sure that it's the right page to overwrite.

}, [isSinglePage, importPageNumber, snapshot.oldPageNumber, pages.data.length])
const { pageNumber, setPageNumber, changePage } = usePagePicker(pages.data.length, defaultDestinationPage)

const setConnectionRemap2 = useCallback(
(fromId: string, toId: string) => {
setConnectionRemap((oldRemap) => ({
Expand Down