Conversation
Resolve baddns conflicts by taking dev's versions wholesale. Domino-specific files (domino.py, presets) preserved.
- Migrate options/options_desc to Pydantic Config class - Use event.url instead of event.data (now a dict) - Emit all findings as FINDING with severity/confidence/name - Remove redundant log property override - Rename domino-medium preset to domino (standard naming) - Update presets: httpx -> http
Replace single shared browser with a pool of dedicated browser instances (one per thread) to prevent deadlocking under concurrent load. Add 120s timeout per URL that kills and replaces hung browsers. Make instance count configurable via browser_instances config option (default 2) with memory usage warning on startup. Add domino-heavy to kitchen-sink preset.
…ent hash Attach body_mmh3 hash to URL events in HTTP module so downstream consumers can access it. Use it in domino's _incoming_dedup_hash to skip URLs with identical response bodies on the same host, avoiding redundant scans of templated pages (e.g. product listings).
Contributor
🚀 Performance Benchmark Report
|
Chromium accumulates internal state (IPC buffers, renderer state) when reused across thousands of URLs, ballooning to 48GB+ virtual memory. Launch and close a browser per URL instead.
# Conflicts: # bbot/modules/http.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.