Skip to content

fix(queue): drop commit pointers and last committed mark if unable to rollback#1104

Closed
SmaGMan wants to merge 2 commits into
masterfrom
fix/drop-queue-commit-pointer
Closed

fix(queue): drop commit pointers and last committed mark if unable to rollback#1104
SmaGMan wants to merge 2 commits into
masterfrom
fix/drop-queue-commit-pointer

Conversation

@SmaGMan

@SmaGMan SmaGMan commented Jun 23, 2026

Copy link
Copy Markdown
Member

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None]


COMPATIBILITY

Fully compatible

SPECIAL DEPLOYMENT ACTIONS

[Not Required]


PERFORMANCE IMPACT

[No impact expected]


TESTS

Unit Tests

[No special coverage]

Network Tests

[No coverage]

Manual Tests

Manual tests used:

  • apply hack to stop node after mc block 20 is accepted
  • set low block gas limit to 8_000_000
  • started local network on 3 nodes
  • start transactions test
  • wait until nodes stop
  • disable hack and restart nodes
  • they should rollback queue and continue collation

@github-actions

Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1104

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1104
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1104 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.28%. Comparing base (d41cb45) to head (93bebc4).

Files with missing lines Patch % Lines
collator/src/queue_adapter.rs 0.00% 21 Missing ⚠️
collator/src/internal_queue/queue.rs 60.71% 10 Missing and 1 partial ⚠️
cli/src/node/mod.rs 0.00% 9 Missing ⚠️
collator/src/internal_queue/state/storage.rs 33.33% 6 Missing and 2 partials ⚠️
collator/src/storage/transaction.rs 0.00% 6 Missing ⚠️
collator/src/state_node.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
- Coverage   60.31%   60.28%   -0.04%     
==========================================
  Files         473      473              
  Lines       80685    80681       -4     
  Branches    80685    80681       -4     
==========================================
- Hits        48668    48636      -32     
- Misses      29692    29711      +19     
- Partials     2325     2334       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SmaGMan SmaGMan force-pushed the fix/drop-queue-commit-pointer branch from 01a8ff6 to 93bebc4 Compare June 25, 2026 08:20
@SmaGMan

SmaGMan commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

replaced with #1105

@SmaGMan SmaGMan closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant