Skip to content

feature(collator): wait until mc block is committed in the node state before committing messages queue#1107

Open
SmaGMan wants to merge 1 commit into
masterfrom
fix/await-mc-block-commit
Open

feature(collator): wait until mc block is committed in the node state before committing messages queue#1107
SmaGMan wants to merge 1 commit into
masterfrom
fix/await-mc-block-commit

Conversation

@SmaGMan

@SmaGMan SmaGMan commented Jun 27, 2026

Copy link
Copy Markdown
Member

This is a follow-up for #1105

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None]


COMPATIBILITY

Fully compatible

SPECIAL DEPLOYMENT ACTIONS

[Not Required]


PERFORMANCE IMPACT

[No impact expected]


TESTS

Unit Tests

Same as in #1105

Network Tests

[No special coverage]

Manual Tests

Same as in #1105

@SmaGMan SmaGMan requested a review from Rexagon June 27, 2026 18:38
@github-actions

Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1107

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1107
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1107 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@SmaGMan SmaGMan requested review from 0xdeafbeef and Mododo June 27, 2026 18:38
@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.60%. Comparing base (45bbd2a) to head (6d31d53).

Files with missing lines Patch % Lines
collator/src/manager/commit.rs 0.00% 3 Missing ⚠️
collator/src/manager/msgs_queue.rs 50.00% 3 Missing ⚠️
collator/src/manager/mod.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
- Coverage   59.63%   59.60%   -0.04%     
==========================================
  Files         484      484              
  Lines       82502    82505       +3     
  Branches    82502    82505       +3     
==========================================
- Hits        49200    49173      -27     
- Misses      30966    30989      +23     
- Partials     2336     2343       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant