feature(collator): wait until mc block is committed in the node state before committing messages queue#1107
Open
SmaGMan wants to merge 1 commit into
Open
feature(collator): wait until mc block is committed in the node state before committing messages queue#1107SmaGMan wants to merge 1 commit into
SmaGMan wants to merge 1 commit into
Conversation
… before committing messages queue
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=1107Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 59.63% 59.60% -0.04%
==========================================
Files 484 484
Lines 82502 82505 +3
Branches 82502 82505 +3
==========================================
- Hits 49200 49173 -27
- Misses 30966 30989 +23
- Partials 2336 2343 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #1105
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
[None]
BLOCKCHAIN CONFIGURATION MODEL CHANGES
[None]
COMPATIBILITY
Fully compatible
SPECIAL DEPLOYMENT ACTIONS
[Not Required]
PERFORMANCE IMPACT
[No impact expected]
TESTS
Unit Tests
Same as in #1105
Network Tests
[No special coverage]
Manual Tests
Same as in #1105