feat(send): "Send now" action on the send-delay (undo) toast#501
Open
shukiv wants to merge 1 commit into
Open
Conversation
The post-send undo toast ('scheduled to send' + Cancel send) now also offers a
'Send now' action that reschedules the delayed submission for immediate release,
so you can skip the undo window without waiting it out. Adds an optional
secondaryAction to the toast component and carries identityId on the pending
undo-send state so the reschedule can target the right identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When send-delay is enabled, sending shows the "scheduled to send" toast with a Cancel send (undo) action. This adds a Send now action to the same toast that releases the delayed message immediately, so you can skip the undo window without waiting it out.
How
toastgains an optionalsecondaryAction(rendered alongside the existing action).identityIdso the immediate send can target the right identity.EmailSubmissionfor ~now (Date.now()+1s), mirroring the existing scheduled-message Send-now, then clears the undo state.Testing
npm run typecheckpasses. Exercised live: send with a delay, toast shows Send now + Cancel send; Send now delivers immediately, Cancel restores the draft.