Protocol work#903
Open
blackspherefollower wants to merge 13 commits into
Open
Conversation
Collaborator
Author
|
This addresses #902. I think this broke in v10, and my test program was just slightly too quick to see the condition triggered. |
Collaborator
Author
|
This now also fixes #904 |
Collaborator
Author
|
And also fixes #868 |
blackspherefollower
force-pushed
the
protocol-work3
branch
from
8840f3c to
d254cd2
Compare
For stroke mode, we want to set the devices to it's most capable. I wish there were a good way to control this though; oscillateWithDepth would be a good fit here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New devices:
Fixes: