Backport security fixes to 1.x#120
Open
markstory wants to merge 2 commits into
Open
Conversation
Ensure that all relative and absolute file paths are contained by a template path. We're looking at the string values so that any `../` tricks don't work. Thanks to Volker Dusch and the PHP Ecosystem security team for reporting this.
The unserialize filter has a weakness to arbitrary class usage which can be combined with user input to create unserialization gadgets which are used in RCE vulnerability chains. I've also chosen to deprecate these functions. I see no reason to continue having them when they have so many sharp edges. Applications relying on these features, can add their own filters. Thanks to Volker Dusch and the PHP Ecosystem security team for reporting this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #119 and #118 to 1.x