rdsview 0.1.3 (new formula)#460
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new Homebrew formula to package rdrview, a command-line tool implementing Firefox's Reader View. The formula fetches the source from GitHub, builds it with make, and includes a test that validates the article extraction and version output.
Changes:
- Adds a new formula
Formula/r/rdsview.rbfor therdrviewtool - Formula installs
rdrviewvia a standardmake/make installbuild - Test block writes a sample HTML file and asserts the CLI correctly extracts article content
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,42 @@ | |||
| class Rdsview < Formula | |||
There was a problem hiding this comment.
The formula is named rdsview (file rdsview.rb, class Rdsview) but the actual upstream project and binary are called rdrview. The homepage, URL, and binary invocation in the test block all use rdrview. The formula file should be renamed to rdrview.rb and the class should be Rdrview to match the actual tool name.
| class Rdsview < Formula | |
| class Rdrview < Formula |
| class Rdsview < Formula | ||
| desc "Firefox Reader View as a command-line tool" | ||
| homepage "https://github.com/eafer/rdrview" | ||
| url "https://github.com/eafer/rdrview/archive/refs/tags/v0.1.5.tar.gz" |
There was a problem hiding this comment.
The PR title states version 0.1.3, but the URL downloads v0.1.5.tar.gz. These should be consistent. If the intent is to package v0.1.5, the PR title and any version references should reflect that. If 0.1.3 is the intended version, the URL tag should be updated to v0.1.3.
No description provided.