Skip to content

rdsview 0.1.3 (new formula)#460

Open
chenrui333 wants to merge 2 commits into
mainfrom
rdsview
Open

rdsview 0.1.3 (new formula)#460
chenrui333 wants to merge 2 commits into
mainfrom
rdsview

Conversation

@chenrui333

Copy link
Copy Markdown
Owner

No description provided.

@chenrui333 chenrui333 added the in progress Stale bot should stay away label Mar 3, 2025
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333

Copy link
Copy Markdown
Owner Author
  ==> make install PREFIX=/opt/homebrew/Cellar/rdsview/0.1.3
  mkdir -p /opt/homebrew/Cellar/rdsview/0.1.3/bin
  cp -f rdrview /opt/homebrew/Cellar/rdsview/0.1.3/bin
  cp: rdrview: No such file or directory
  make: *** [install] Error 1

@chenrui333 chenrui333 added the build failure CI fails while building the software label Jun 14, 2025
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 19, 2026
Copilot AI review requested due to automatic review settings March 8, 2026 01:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Homebrew formula to package rdrview, a command-line tool implementing Firefox's Reader View. The formula fetches the source from GitHub, builds it with make, and includes a test that validates the article extraction and version output.

Changes:

  • Adds a new formula Formula/r/rdsview.rb for the rdrview tool
  • Formula installs rdrview via a standard make / make install build
  • Test block writes a sample HTML file and asserts the CLI correctly extracts article content

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Formula/r/rdsview.rb
@@ -0,0 +1,42 @@
class Rdsview < Formula

Copilot AI Mar 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formula is named rdsview (file rdsview.rb, class Rdsview) but the actual upstream project and binary are called rdrview. The homepage, URL, and binary invocation in the test block all use rdrview. The formula file should be renamed to rdrview.rb and the class should be Rdrview to match the actual tool name.

Suggested change
class Rdsview < Formula
class Rdrview < Formula

Copilot uses AI. Check for mistakes.
Comment thread Formula/r/rdsview.rb
class Rdsview < Formula
desc "Firefox Reader View as a command-line tool"
homepage "https://github.com/eafer/rdrview"
url "https://github.com/eafer/rdrview/archive/refs/tags/v0.1.5.tar.gz"

Copilot AI Mar 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title states version 0.1.3, but the URL downloads v0.1.5.tar.gz. These should be consistent. If the intent is to package v0.1.5, the PR title and any version references should reflect that. If 0.1.3 is the intended version, the URL tag should be updated to v0.1.3.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. in progress Stale bot should stay away new formula

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants