Skip to content

Remove spacers in non-LargeSideBar modes for FancyTabWidget - #6165

Open
amhndu wants to merge 1 commit into
clementine-player:masterfrom
amhndu:spacers-fancytabwidget
Open

Remove spacers in non-LargeSideBar modes for FancyTabWidget#6165
amhndu wants to merge 1 commit into
clementine-player:masterfrom
amhndu:spacers-fancytabwidget

Conversation

@amhndu

@amhndu amhndu commented Oct 7, 2018

Copy link
Copy Markdown
Contributor

To maintain behavior with the older FancyTabWidget, spacers are now
removed and stored when switching to a non-LargeSideBar mode.
And subsequently restored when switching back to LargeSideBar mode.

Fixes #6163

@amhndu
amhndu force-pushed the spacers-fancytabwidget branch from 919624d to 789251f Compare October 7, 2018 10:15
@jonaski

jonaski commented Oct 7, 2018

Copy link
Copy Markdown
Contributor

Is there any reason why this is done on qt5 and not master?
You should make the pull requests on master unless it's a specific fix only to Qt 5, otherwise it makes it harder to merge.

@amhndu

amhndu commented Oct 7, 2018

Copy link
Copy Markdown
Contributor Author

Thanks, I wasn't really aware. I thought qt5 is the main development branch

@amhndu

amhndu commented Oct 7, 2018

Copy link
Copy Markdown
Contributor Author

@jonaski A different PR of mine was merged to qt5 similarly, should I make a new PR cherry-picking that onto master ? (and similarly for this)

@jonaski

jonaski commented Oct 7, 2018

Copy link
Copy Markdown
Contributor

I'm not the project owner or maintainer here. But I suggest that yes.
Whats done until now is that we create PRs mainly on master and then we merge master into qt 5.
As long as they want to still keep Qt 4 support and have that in master.

To maintain behavior with the older FancyTabWidget, spacers are now
removed and stored when switching to a non-LargeSideBar mode.
And subsequently restored when switching back to LargeSideBar mode.
@amhndu
amhndu changed the base branch from qt5 to master October 7, 2018 10:48
@amhndu
amhndu force-pushed the spacers-fancytabwidget branch from 789251f to f13e8d7 Compare October 7, 2018 10:50
@ghost

ghost commented Nov 8, 2018

Copy link
Copy Markdown

I wonder if there's a reason to keep master on Qt 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants