Remove spacers in non-LargeSideBar modes for FancyTabWidget - #6165
Open
amhndu wants to merge 1 commit into
Open
Conversation
amhndu
force-pushed
the
spacers-fancytabwidget
branch
from
October 7, 2018 10:15
919624d to
789251f
Compare
Contributor
|
Is there any reason why this is done on qt5 and not master? |
Contributor
Author
|
Thanks, I wasn't really aware. I thought qt5 is the main development branch |
Contributor
Author
|
@jonaski A different PR of mine was merged to qt5 similarly, should I make a new PR cherry-picking that onto master ? (and similarly for this) |
Contributor
|
I'm not the project owner or maintainer here. But I suggest that yes. |
To maintain behavior with the older FancyTabWidget, spacers are now removed and stored when switching to a non-LargeSideBar mode. And subsequently restored when switching back to LargeSideBar mode.
amhndu
force-pushed
the
spacers-fancytabwidget
branch
from
October 7, 2018 10:50
789251f to
f13e8d7
Compare
3 tasks
|
I wonder if there's a reason to keep master on Qt 4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To maintain behavior with the older FancyTabWidget, spacers are now
removed and stored when switching to a non-LargeSideBar mode.
And subsequently restored when switching back to LargeSideBar mode.
Fixes #6163