Skip to content

Update obsolete build dependencies in debian control file - #7106

Open
muzena wants to merge 2 commits into
clementine-player:masterfrom
muzena:update_debian_build
Open

Update obsolete build dependencies in debian control file#7106
muzena wants to merge 2 commits into
clementine-player:masterfrom
muzena:update_debian_build

Conversation

@muzena

@muzena muzena commented Oct 13, 2021

Copy link
Copy Markdown

@lumip
It's control file from debian package

@hatstand

Copy link
Copy Markdown
Contributor

Could you make the commit messages more informative, please?

@muzena

muzena commented Oct 15, 2021

Copy link
Copy Markdown
Author

@hatstand

Could you make the commit messages more informative, please?

It failed to build on Ubuntu and debian those dependencies dosen't exist anymore on debian or ubuntu even on obsolete version like Ubuntu Trusty eg. libqt5-dev, qt5-dev-tools...
Im trying to setup PPA autobuild since official PPA are failed to build since 2017 year.

@hatstand

Copy link
Copy Markdown
Contributor

Yes, I understand what this is fixing but we'd prefer to have commits with more informative messages than "Update control" for the benefit of people trying to understand these changes later.

@muzena

muzena commented Oct 16, 2021

Copy link
Copy Markdown
Author

@hatstand
Do you use this debian folder for building deb's?
Can you look in debian repo patches folder, do those patches fix something, or they are specific only for Debian/Ubuntu distors?

@hatstand

Copy link
Copy Markdown
Contributor

@hatstand Do you use this debian folder for building deb's? Can you look in debian repo patches folder, do those patches fix something, or they are specific only for Debian/Ubuntu distors?

I think they're mostly for compliance with Debian's various policies.

@muzena

muzena commented Oct 21, 2021

Copy link
Copy Markdown
Author

@hatstand
This won't work in PPA build because changelog is broken, missing date in changelog.
Is problem for you to move debian directory to package/debian or pkg/debian, then is possible in PPA build recipes to nest 'debian dir' from debian for proper building?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants