[filebrowser] fix: normalize paths in copy/move same-path guard#4341
Open
HalimKim wants to merge 1 commit into
Open
[filebrowser] fix: normalize paths in copy/move same-path guard#4341HalimKim wants to merge 1 commit into
HalimKim wants to merge 1 commit into
Conversation
Copying or moving a directory to the same path with only a trailing-slash difference (e.g. /user/systest/tmp -> /user/systest/tmp/) bypassed the raw string equality guard. webhdfs then normalized the slash away, appended the source basename to the existing destination dir, and recursed into the freshly created subdirectory, producing an infinitely nested copy. Compare request.fs.normpath() of both paths so semantically identical paths are detected as the same. Add tests covering the trailing-slash rejection and the genuinely-different-destination happy path for both copy and move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying or moving a directory to the same path with only a trailing-slash difference (e.g. /user/systest/tmp -> /user/systest/tmp/) bypassed the raw string equality guard. webhdfs then normalized the slash away, appended the source basename to the existing destination dir, and recursed into the freshly created subdirectory, producing an infinitely nested copy.
Compare request.fs.normpath() of both paths so semantically identical paths are detected as the same. Add tests covering the trailing-slash rejection and the genuinely-different-destination happy path for both copy and move.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.