Skip to content

Set network-specific 2FA token issuers#2085

Merged
ArtOfCode- merged 3 commits into
developfrom
art/2fa-tokens
Jul 10, 2026
Merged

Set network-specific 2FA token issuers#2085
ArtOfCode- merged 3 commits into
developfrom
art/2fa-tokens

Conversation

@ArtOfCode-

Copy link
Copy Markdown
Member

Closes #2084

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.72%. Comparing base (3663405) to head (6dcee3b).

Additional details and impacted files
Components Coverage Δ
controllers 76.42% <100.00%> (+0.29%) ⬆️
helpers 85.47% <ø> (ø)
jobs 77.43% <ø> (ø)
models 93.08% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread app/controllers/two_factor_controller.rb

@Oaphi Oaphi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArtOfCode- I've added a basic test to improve coverage of (well, more like to start covering) the controller, leaving it up to you to merge if the test looks good to you (LGTM, tested the new setting manually as well).

@ArtOfCode- ArtOfCode- merged commit a981fe0 into develop Jul 10, 2026
20 of 22 checks passed
@ArtOfCode- ArtOfCode- deleted the art/2fa-tokens branch July 10, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2FA tokens always use codidact.com rather than the network name

2 participants