Skip to content

fix: update snapshot, bump R minimum to 4.1, modernize GHA workflows #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IndrajeetPatil merged 6 commits into from
Mar 29, 2026
Merged

fix: update snapshot, bump R minimum to 4.1, modernize GHA workflows #152

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a821c4
fix: update snapshot, bump R minimum to 4.1, modernize GHA workflows
IndrajeetPatil Mar 29, 2026
3b3a27a
fix: remove Twitter/X entries from author comments in DESCRIPTION
IndrajeetPatil Mar 29, 2026
7fd853a
docs: regenerate Rd files with roxygen2 7.3.3
IndrajeetPatil Mar 29, 2026
804e2b3
ci: rewrite R-CMD-check matrix to use oldrel-N notation
IndrajeetPatil Mar 29, 2026
8f8dae3
fix: address PR review comments
IndrajeetPatil Mar 29, 2026
ec6bd22
test: skip snapshot tests on R-devel
IndrajeetPatil Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions .github/workflows/check-full.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:

name: R-CMD-check

concurrency:
group: ${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: true

jobs:
R-CMD-check:
runs-on: ${{ matrix.config.os }}
Expand All @@ -16,32 +20,25 @@ jobs:
fail-fast: false
matrix:
config:
# CRAN doesn't provide binaries for macOS on R-devel, so skip because
# it will be too slow otherwise
#- {os: macOS-latest, r: 'devel'}
- { os: macOS-latest, r: "release" }

- { os: windows-latest, r: "devel" }
- { os: windows-latest, r: "release" }
- { os: windows-latest, r: "oldrel" }
- {os: macOS-latest, r: 'release'}

- {os: windows-latest, r: 'release'}
# use 4.1 to check with rtools40's older compiler
- { os: windows-latest, r: "4.1" }
- {os: windows-latest, r: '4.1'}

#- { os: ubuntu-latest, r: "next" }
- { os: ubuntu-latest, r: "devel" }
- { os: ubuntu-latest, r: "release" }
- { os: ubuntu-latest, r: "4.3" }
- { os: ubuntu-latest, r: "4.2" }
- { os: ubuntu-latest, r: "4.1" }
- { os: ubuntu-latest, r: "4.0" }
- { os: ubuntu-latest, r: "3.6" }
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}
- {os: ubuntu-latest, r: 'oldrel-2'}
- {os: ubuntu-latest, r: 'oldrel-3'}
- {os: ubuntu-latest, r: 'oldrel-4'}
Comment thread
IndrajeetPatil marked this conversation as resolved.
Outdated

env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

Comment thread
IndrajeetPatil marked this conversation as resolved.
- uses: r-lib/actions/setup-pandoc@v2

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
runs-on: ubuntu-latest
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
steps:
- uses: actions/checkout@v4

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pkgdown.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
runs-on: ubuntu-latest
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
steps:
- uses: actions/checkout@v4

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/test-coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
runs-on: ubuntu-latest
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

steps:
- uses: actions/checkout@v4
Expand All @@ -23,7 +24,7 @@ jobs:

- uses: r-lib/actions/setup-r-dependencies@v2
with:
extra-packages: r-lib/covr
extra-packages: any::covr
needs: coverage

- name: Test coverage
Expand Down
8 changes: 4 additions & 4 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ Authors@R:
family = "Ahlmann-Eltze",
role = c("aut", "cre", "ctb"),
email = "artjom31415@googlemail.com",
comment = c(ORCID = "0000-0002-3762-068X", Twitter = "@const_ae")),
comment = c(ORCID = "0000-0002-3762-068X")),
person(given = "Indrajeet",
family = "Patil",
role = c("aut", "ctb"),
email = "patilindrajeet.science@gmail.com",
comment = c(ORCID = "0000-0003-1995-6531", Twitter = "@patilindrajeets"))
comment = c(ORCID = "0000-0003-1995-6531"))
)
Description: Enrich your 'ggplots' with group-wise comparisons.
This package provides an easy way to indicate if two groups are
Expand All @@ -32,7 +32,7 @@ VignetteBuilder:
Encoding: UTF-8
Language: en-US
Depends:
R (>= 3.6.0)
R (>= 4.1.0)
Imports:
ggplot2 (>= 3.5.0)
Suggests:
Expand All @@ -42,6 +42,6 @@ Suggests:
testthat,
vdiffr (>= 1.0.7)
Roxygen: list(markdown = TRUE, roclets = c("rd", "namespace", "collate"))
RoxygenNote: 7.3.1
RoxygenNote: 7.3.3
Config/testthat/edition: 3
Config/testthat/parallel: true
4 changes: 2 additions & 2 deletions man/ggsignif-package.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 28 additions & 10 deletions man/stat_signif.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions tests/testthat/_snaps/geom_signific_strict.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@
pb$data
Output
[[1]]
fill x y PANEL group flipped_aes ymin ymax xmin xmax colour linewidth
1 grey80 0.875 3 1 1 FALSE 0 3 0.75 1.00 NA 0.5
2 grey20 1.125 5 1 3 FALSE 0 5 1.00 1.25 NA 0.5
3 grey80 1.875 7 1 2 FALSE 0 7 1.75 2.00 NA 0.5
4 grey20 2.125 8 1 4 FALSE 0 8 2.00 2.25 NA 0.5
linetype alpha
1 1 NA
2 1 NA
3 1 NA
4 1 NA
fill x y PANEL group flipped_aes ymin ymax xmin xmax order colour
1 grey80 0.875 3 1 1 FALSE 0 3 0.75 1.00 1 NA
2 grey20 1.125 5 1 3 FALSE 0 5 1.00 1.25 2 NA
3 grey80 1.875 7 1 2 FALSE 0 7 1.75 2.00 1 NA
4 grey20 2.125 8 1 4 FALSE 0 8 2.00 2.25 2 NA
linewidth linetype alpha width
1 0.5 1 NA 0.5
2 0.5 1 NA 0.5
3 0.5 1 NA 0.5
4 0.5 1 NA 0.5

[[2]]
x y xend yend annotation PANEL group shape colour textsize angle hjust
Expand Down
Loading