Skip to content

fix(gui): contain sidebar markdown overflow #12940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JSap0914 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −6
Open

fix(gui): contain sidebar markdown overflow #12940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gui/src/components/StepContainer/StepContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ export default function StepContainer(props: StepContainerProps) {
}

return (
<div>
<div className="min-w-0">
<div
className={`bg-background p-1 px-1.5 ${isBeforeLatestSummary ? "opacity-35" : ""}`}
className={`bg-background min-w-0 p-1 px-1.5 ${isBeforeLatestSummary ? "opacity-35" : ""}`}
>
{uiConfig?.displayRawMarkdown ? (
<pre className="text-2xs max-w-full overflow-x-auto whitespace-pre-wrap break-words p-4">
Expand Down
8 changes: 7 additions & 1 deletion gui/src/components/StyledMarkdownPreview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const StyledMarkdown = styled.div<{
whiteSpace: string;
bgColor: string;
}>`
min-width: 0;
max-width: 100%;
h1 {
font-size: 1.25em;
}
Expand Down Expand Up @@ -66,7 +68,9 @@ const StyledMarkdown = styled.div<{
background-color: ${vscEditorBackground};
border-radius: ${defaultBorderRadius};

max-width: calc(100vw - 24px);
box-sizing: border-box;
min-width: 0;
max-width: 100%;
overflow-x: scroll;
overflow-y: hidden;

Expand All @@ -77,6 +81,8 @@ const StyledMarkdown = styled.div<{
span.line:empty {
display: none;
}
overflow-wrap: anywhere;
word-break: break-word;
word-wrap: break-word;
border-radius: 0.3125rem;
background-color: ${vscEditorBackground};
Expand Down
4 changes: 2 additions & 2 deletions gui/src/pages/gui/Chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ export function Chat() {

// Default case - regular assistant message
return (
<div className="thread-message">
<div className="thread-message min-w-0">
<TimelineItem
item={item}
iconElement={<ChatBubbleOvalLeftIcon width="16px" height="16px" />}
Expand Down Expand Up @@ -386,7 +386,7 @@ export function Chat() {

<StepsDiv
ref={stepsDivRef}
className={`pt-[8px] ${showScrollbar ? "thin-scrollbar" : "no-scrollbar"} ${history.length > 0 ? "min-h-0 flex-1 overflow-y-scroll" : "shrink-0"}`}
className={`min-w-0 pt-[8px] ${showScrollbar ? "thin-scrollbar" : "no-scrollbar"} ${history.length > 0 ? "min-h-0 flex-1 overflow-x-hidden overflow-y-scroll" : "shrink-0"}`}
>
<DeprecationBanner dismissable={true} />
{highlights}
Expand Down
2 changes: 1 addition & 1 deletion gui/src/pages/gui/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default function GUI() {
<aside className="4xl:flex border-vsc-input-border no-scrollbar hidden min-h-0 w-96 overflow-y-auto border-0 border-r border-solid">
<History />
</aside>
<main className="no-scrollbar flex min-h-0 flex-1 flex-col">
<main className="no-scrollbar flex min-h-0 min-w-0 flex-1 flex-col">
<Chat />
</main>
</div>
Expand Down
Loading