feat: gate dev warehouse auto-resolution behind opt-in env var#460
Draft
MarioCadenas wants to merge 1 commit into
Draft
feat: gate dev warehouse auto-resolution behind opt-in env var#460MarioCadenas wants to merge 1 commit into
MarioCadenas wants to merge 1 commit into
Conversation
Auto-resolving a SQL warehouse in development previously triggered
whenever NODE_ENV=development and DATABRICKS_WAREHOUSE_ID was unset.
This conflated "running locally" with "silently pick a warehouse for
me", which is convenient for the dev-playground but surprising for real
apps (e.g. the Genie app builder) that share the same template dev
script.
Auto-resolution now additionally requires APPKIT_AUTO_RESOLVE_WAREHOUSE
to be set ("1" or "true"); the NODE_ENV=development guard is retained so
it can never auto-pick in production. The dev-playground opts in via its
dev scripts to preserve current zero-config behavior.
BEHAVIOR CHANGE: apps scaffolded from the template no longer auto-resolve
a warehouse in dev unless they set APPKIT_AUTO_RESOLVE_WAREHOUSE.
Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-resolving a SQL warehouse in development previously triggered whenever NODE_ENV=development and DATABRICKS_WAREHOUSE_ID was unset. This conflated "running locally" with "silently pick a warehouse for me", which is convenient for the dev-playground but surprising for real apps (e.g. the Genie app builder) that share the same template dev script.
Auto-resolution now additionally requires APPKIT_AUTO_RESOLVE_WAREHOUSE to be set ("1" or "true"); the NODE_ENV=development guard is retained so it can never auto-pick in production. The dev-playground opts in via its dev scripts to preserve current zero-config behavior.
BEHAVIOR CHANGE: apps scaffolded from the template no longer auto-resolve a warehouse in dev unless they set APPKIT_AUTO_RESOLVE_WAREHOUSE.