fix(calibrate_response_mapper): honor output_pattern when set - #1017
Merged
Conversation
parse_output() previously ignored self.output_pattern entirely, always returning the raw stripped text. Now applies the regex when the user provides a custom output_pattern, falling back to the original strip behavior otherwise. Pulp-Item: fine_a11f905aa2b4
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
yxdyc
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CalibrateResponseMapper.parse_output()ignores theoutput_patternparameter entirely. The parent classCalibrateQAMapperusesself.output_patternfor regex extraction, butCalibrateResponseMapperoverridesparse_outputto always returnraw_output.strip(), making the parameter a no-op.Before fix: User sets
output_pattern: 'Answer:\\s*(.*)'', gets back full raw text'Answer: my calibrated response'.After fix: Regex is applied, correctly extracts
'my calibrated response'.Fix
When the user provides a custom
output_pattern(different fromDEFAULT_OUTPUT_PATTERN), apply regex matching. Fall back to the original strip behavior if no custom pattern is set or if regex doesn't match.Test