Skip to content

Multiplatform adjustments - #252

Merged
itaihanski merged 8 commits into
mainfrom
multiplatform-adjustments
Sep 14, 2025
Merged

Multiplatform adjustments#252
itaihanski merged 8 commits into
mainfrom
multiplatform-adjustments

Conversation

@itaihanski

Copy link
Copy Markdown
Member

Related Issues

https://github.com/descope/etc/issues/8189

Description

A few adjustments to expose some function for the multi-platform SDKs using this SDK and align the DescopeUser fields

Must

  • Tests
  • Documentation (if applicable)

@itaihanski itaihanski self-assigned this Sep 9, 2025
Copilot AI review requested due to automatic review settings September 9, 2025 13:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new fields to the DescopeUser data class to support multi-platform SDKs and improves the visibility of certain functions. The changes include adding password status, user status, role names, SSO app IDs, and OAuth providers to the user model, along with exposing previously internal functions for external SDK use.

  • Adds five new fields to DescopeUser: hasPassword, status, roleNames, ssoAppIds, and oauthProviders
  • Exposes internal functions (getPackageOrigin, performRegister, performAssertion, performNativeAuthorization) as public
  • Moves SystemInfo interface from internal.http to android package for better accessibility

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
User.kt Adds new user properties for password status, user status, roles, SSO apps, and OAuth providers
SystemInfo.kt Moves SystemInfo interface from internal package to public android package
Responses.kt Updates UserResponse to include new fields with proper JSON parsing
Storage.kt Updates user serialization/deserialization to handle new fields
Shared.kt Updates user conversion logic to map new response fields
Passkey.kt Exposes passkey-related functions as public and removes API level restriction
OAuth.kt Exposes native authorization function as public
Utils.kt Improves JSON parsing utilities with type safety
DescopeClient.kt Updates import for moved SystemInfo
Sdk.kt Updates import for moved SystemInfo
TestUtils.kt Updates mock data and imports for testing
AuthTest.kt Updates test data to include new user fields

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread descopesdk/src/main/java/com/descope/types/User.kt Outdated
Comment thread descopesdk/src/main/java/com/descope/internal/routes/Passkey.kt
@itaihanski
itaihanski merged commit a6222ba into main Sep 14, 2025
9 checks passed
@itaihanski
itaihanski deleted the multiplatform-adjustments branch September 14, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants