Multiplatform adjustments - #252
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds new fields to the DescopeUser data class to support multi-platform SDKs and improves the visibility of certain functions. The changes include adding password status, user status, role names, SSO app IDs, and OAuth providers to the user model, along with exposing previously internal functions for external SDK use.
- Adds five new fields to DescopeUser: hasPassword, status, roleNames, ssoAppIds, and oauthProviders
- Exposes internal functions (getPackageOrigin, performRegister, performAssertion, performNativeAuthorization) as public
- Moves SystemInfo interface from internal.http to android package for better accessibility
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| User.kt | Adds new user properties for password status, user status, roles, SSO apps, and OAuth providers |
| SystemInfo.kt | Moves SystemInfo interface from internal package to public android package |
| Responses.kt | Updates UserResponse to include new fields with proper JSON parsing |
| Storage.kt | Updates user serialization/deserialization to handle new fields |
| Shared.kt | Updates user conversion logic to map new response fields |
| Passkey.kt | Exposes passkey-related functions as public and removes API level restriction |
| OAuth.kt | Exposes native authorization function as public |
| Utils.kt | Improves JSON parsing utilities with type safety |
| DescopeClient.kt | Updates import for moved SystemInfo |
| Sdk.kt | Updates import for moved SystemInfo |
| TestUtils.kt | Updates mock data and imports for testing |
| AuthTest.kt | Updates test data to include new user fields |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shilgapira
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
https://github.com/descope/etc/issues/8189
Description
A few adjustments to expose some function for the multi-platform SDKs using this SDK and align the DescopeUser fields
Must