Use the authentication response cookie fields to search for flow cookies - #258
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the authentication cookie search mechanism to use both URL and response cookie fields when searching for flow cookies, improving cookie discovery in authentication flows.
- Refactored
findJwtInCookiesfunction to accept multiple cookie strings with named parameters - Added new cookie fields (
cookieDomainandcookiePath) to JWT server responses - Updated authentication flow to search cookies from both the original URL and response-specified domain/path
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TokenTest.kt | Updated test calls to use the new parameter order and added tests for multiple cookie string scenarios |
| TestUtils.kt | Added mock cookie domain and path fields to test JWT response |
| Responses.kt | Added cookieDomain and cookiePath fields to JwtServerResponse data class |
| DescopeFlowCoordinator.kt | Refactored cookie search to use both URL and response cookie locations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
itaihanski
enabled auto-merge (squash)
September 30, 2025 14:57
shilgapira
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
https://github.com/descope/etc/issues/12304
Description
Use the authentication response cookie fields to search for flow cookies
Must