Add support for push authentication - #308
Merged
Merged
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
There was a problem hiding this comment.
Pull request overview
Adds Android SDK support for push-notification-based authentication by exposing a new DescopePush API, wiring it into the SDK/singleton, and implementing the underlying HTTP routes in DescopeClient.
Changes:
- Introduces the public
DescopePushinterface (enroll,finish) and exposes it viaDescopeSdkand theDescopesingleton. - Adds an internal
Pushroute implementation that delegates to newDescopeClientpush endpoints. - Implements push HTTP calls in
DescopeClient(auth/push/update,auth/push/signin/finish) and makessystemInfoaccessible to route code.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| descopesdk/src/main/java/com/descope/sdk/Sdk.kt | Adds push route to the instantiated SDK routes set. |
| descopesdk/src/main/java/com/descope/sdk/Routes.kt | Defines the new public DescopePush interface and KDoc. |
| descopesdk/src/main/java/com/descope/internal/routes/Push.kt | Implements DescopePush by calling the corresponding client endpoints. |
| descopesdk/src/main/java/com/descope/internal/http/DescopeClient.kt | Adds push enroll/finish HTTP endpoints; exposes systemInfo for device naming. |
| descopesdk/src/main/java/com/descope/Descope.kt | Exposes Descope.push on the singleton API surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # descopesdk/src/main/java/com/descope/Descope.kt
shilgapira
enabled auto-merge (squash)
July 13, 2026 13:04
itaihanski
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Must