Skip to content

Add support for push authentication - #308

Merged
shilgapira merged 2 commits into
mainfrom
push-auth
Jul 13, 2026
Merged

Add support for push authentication#308
shilgapira merged 2 commits into
mainfrom
push-auth

Conversation

@shilgapira

Copy link
Copy Markdown
Member

Description

  • Add support for push authentication

Must

  • Tests
  • Documentation (if applicable)

@shilgapira
shilgapira requested a review from itaihanski March 31, 2026 15:09
@shilgapira shilgapira self-assigned this Mar 31, 2026
Copilot AI review requested due to automatic review settings March 31, 2026 15:09
@shuni-bot-dev

shuni-bot-dev Bot commented Mar 31, 2026

Copy link
Copy Markdown

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot-dev shuni-bot-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Adds push authentication support (enroll device via FCM + approve/deny sign-in transactions). Clean, well-structured addition following existing patterns.

No issues found — good bones! Woof!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Android SDK support for push-notification-based authentication by exposing a new DescopePush API, wiring it into the SDK/singleton, and implementing the underlying HTTP routes in DescopeClient.

Changes:

  • Introduces the public DescopePush interface (enroll, finish) and exposes it via DescopeSdk and the Descope singleton.
  • Adds an internal Push route implementation that delegates to new DescopeClient push endpoints.
  • Implements push HTTP calls in DescopeClient (auth/push/update, auth/push/signin/finish) and makes systemInfo accessible to route code.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
descopesdk/src/main/java/com/descope/sdk/Sdk.kt Adds push route to the instantiated SDK routes set.
descopesdk/src/main/java/com/descope/sdk/Routes.kt Defines the new public DescopePush interface and KDoc.
descopesdk/src/main/java/com/descope/internal/routes/Push.kt Implements DescopePush by calling the corresponding client endpoints.
descopesdk/src/main/java/com/descope/internal/http/DescopeClient.kt Adds push enroll/finish HTTP endpoints; exposes systemInfo for device naming.
descopesdk/src/main/java/com/descope/Descope.kt Exposes Descope.push on the singleton API surface.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread descopesdk/src/main/java/com/descope/internal/routes/Push.kt
# Conflicts:
#	descopesdk/src/main/java/com/descope/Descope.kt
@shilgapira
shilgapira enabled auto-merge (squash) July 13, 2026 13:04
@shilgapira
shilgapira merged commit 034b5cd into main Jul 13, 2026
11 checks passed
@shilgapira
shilgapira deleted the push-auth branch July 13, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants