Skip to content

feat: expose externalToken on AuthenticationResponse - #336

Merged
itaihanski merged 1 commit into
mainfrom
feat/external-token
Jul 12, 2026
Merged

feat: expose externalToken on AuthenticationResponse#336
itaihanski merged 1 commit into
mainfrom
feat/external-token

Conversation

@itaihanski

@itaihanski itaihanski commented Jul 12, 2026

Copy link
Copy Markdown
Member

Related Issues

https://github.com/descope/etc/issues/16830

Description

  • Populate AuthenticationResponse.externalToken: String? from the server auth response
  • Parsed on JwtServerResponse and passed through convert(), matching the Flutter and web SDKs

Must

  • Tests
  • Documentation

@shuni-bot

shuni-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

🐕 Suggested Reviewers

Selected the contributor who has contributed extensively across the relevant files to ensure broad expertise and familiarity with the code areas impacted by this PR.

Reviewer Reason
shilgapira ShilgaPira reviewed multiple files, including Responses.kt and TestUtils.kt, covering both main and test code relevant to the change.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Exposes AuthenticationResponse.externalToken populated from the server auth response, threaded cleanly through JwtServerResponseconvert() → the public type.

No issues found — good bones! Parsing uses stringOrEmptyAsNull like sibling fields, the new nullable is defaulted, and both present/absent cases have tests. Woof!

@itaihanski
itaihanski merged commit af819f0 into main Jul 12, 2026
11 checks passed
@itaihanski
itaihanski deleted the feat/external-token branch July 12, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants