feat: expose externalToken on AuthenticationResponse - #336
Merged
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersSelected the contributor who has contributed extensively across the relevant files to ensure broad expertise and familiarity with the code areas impacted by this PR.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni's Review
Exposes AuthenticationResponse.externalToken populated from the server auth response, threaded cleanly through JwtServerResponse → convert() → the public type.
No issues found — good bones! Parsing uses stringOrEmptyAsNull like sibling fields, the new nullable is defaulted, and both present/absent cases have tests. Woof!
2 tasks
asafshen
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
https://github.com/descope/etc/issues/16830
Description
AuthenticationResponse.externalToken: String?from the server auth responseJwtServerResponseand passed throughconvert(), matching the Flutter and web SDKsMust