ci: integrate release-please and cut 0.19.1 - #337
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe review assignment focuses on covering different areas affected by the release process, with one reviewer responsible for SDK code changes. Since the other files are related to CI workflows and release configuration, the primary reviewer for code content is shilgapira, ensuring thorough review of SDK-related updates.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Cuts 0.19.1 manually and wires up release-please + Conventional-Commit PR-title linting to automate future releases.
No issues found — good bones! The pull_request_target lint job doesn't check out PR code, the release job uses a GitHub App token (so no workflow permissions block needed), and the config/manifest/x-release-please-version annotation all line up. Woof!
Manual 0.19.1 release bundled with release-please setup. Versions pushed by hand in this PR (manifest, Sdk.kt, CHANGELOG all set to 0.19.1); tag 0.19.1 is created manually after merge to trigger publish.yml. release-please (templated from the Flutter and React Native SDKs) ships dormant - it ignores this ci/chore commit and takes over from 0.19.1 on the next feat/fix: - release-please-config.json (release-type: simple, include-v-in-tag: false to match existing non-v tags) + .release-please-manifest.json - release-please.yml workflow (GitHub App token so the release it creates still triggers publish.yml) - lint-pr.yml to enforce Conventional Commit PR titles - Sdk.kt VERSION annotated with x-release-please-version for auto-bump publish.yml is unchanged - both manual and automated releases converge on the same release:created trigger.
ee01c8c to
47abf37
Compare
3 participants
Description
0.19.1manually — versions pushed by hand (.release-please-manifest.json,Sdk.ktVERSION,CHANGELOG.md); tag0.19.1created manually after merge to triggerpublish.yml0.19.1on the nextfeat/fixrelease-please-config.json:release-type: simple,include-v-in-tag: falseto match existing non-vtags;Sdk.ktVERSIONannotated withx-release-please-versionfor auto-bumprelease-please.yml: runs on push tomain, authenticates with a GitHub App token so the release it creates still triggerspublish.ymllint-pr.yml: enforce Conventional Commit PR titlespublish.ymlunchanged — manual and automated releases converge on the samerelease: createdtrigger