feat(mcp): accept field-fill params on send_documents tool#635
Open
Ortes wants to merge 1 commit into
Open
Conversation
Mirror the REST API by accepting values, fields, readonly_fields, metadata, external_id, completed, role and message per submitter. Input is normalized via Submissions::NormalizeParamUtils so field names resolve to UUIDs and default_value entries merge into values. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the MCP
send_documentstool to parity with the RESTPOST /submissionsendpoint for pre-filling submitter fields. Previously, MCP callers could only setemail,name,phone,roleper submitter — anyvalues/fieldspayload was silently dropped.What changed
lib/mcp/tools/send_documents.rbnow accepts per submitter:values— pre-fill field values, keyed by field UUID or field name.fields— per-field overrides (default_value,value,title,description,readonly,required,validation_pattern,invalid_message).readonly_fields— field names to lock for this submitter.metadata,external_id,completed,role,message(subject/body).The input is normalized via
Submissions::NormalizeParamUtils.normalize_submissions_params!before handoff toSubmissions.create_from_submitters, matching the exact pipeline used byApi::SubmissionsController#create. The rescue block mirrors the same controller soSubmitters::NormalizeValues::BaseErrorandDownloadUtils::UnableToDownloadsurface as clean MCP error responses.Backward compatible: existing callers that only pass
email/name/phone/rolekeep working unchanged.Test plan
send_documentswith avalueshash keyed by field name → verify values resolve to UUIDs and the submitter is created with the correct defaults.send_documentswithfields: [{ name: "...", default_value: "..." }]→ verify the default is merged into values.UnknownFieldName).email/name(legacy shape) → verify behavior unchanged.🤖 Generated with Claude Code