Skip to content

feat: show plaintext TOTP secret during 2FA setup #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ltianyi992 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: show plaintext TOTP secret during 2FA setup #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/views/mfa_setup/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
<div>
<%== RQRCode::QRCode.new(@provision_url).as_svg(viewbox: true, svg_attributes: { class: 'md:w-80 md:h-80 my-4 mx-auto' }) %>
</div>
<div class="text-center my-2">
<p class="text-sm text-base-content/70"><%= t('or_enter_this_key_manually') %>:</p>
<code class="font-mono text-sm select-all bg-base-200 px-2 py-1 rounded break-all"><%= current_user.otp_secret %></code>
</div>
<div class="form-control my-6 space-y-2">
<%= f.text_field :otp_attempt, required: true, placeholder: 'XXX-XXX', class: 'base-input text-center' %>
<span>
Expand Down
1 change: 1 addition & 0 deletions config/locales/i18n.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ en: &en
confirm_password: Confirm new password
save_password_and_sign_in: Save password and Sign in
use_an_authenticator_mobile_app_like_google_authenticator_or_1password_to_scan_the_qr_code_below: Use an authenticator mobile app like Google Authenticator or 1Password to scan the QR code below.
or_enter_this_key_manually: Or enter this key manually
remove_2fa: Remove 2FA
setup_2fa: Setup 2FA
2fa_has_been_configured: 2FA has been configured.
Expand Down