[tests] Disable flaky TryFindClass UTF-8 gref test#12032
Open
simonrozsival wants to merge 4 commits into
Open
Conversation
Temporarily ignore TryFindClass_Utf8_DoesNotLeakGlobalRefs while the frequent CI failure is tracked in #12031. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Temporarily disables a flaky Java.Interop UTF-8 TryFindClass global-reference leak test to reduce CI noise while the underlying issue is investigated (#12031).
Changes:
- Adds an NUnit
[Ignore]attribute toTryFindClass_Utf8_DoesNotLeakGlobalRefs.
Show a summary per file
| File | Description |
|---|---|
| external/Java.Interop/tests/Java.Interop-Tests/Java.Interop/JniTypeUtf8Test.cs | Marks the flaky TryFindClass_Utf8_DoesNotLeakGlobalRefs test as ignored with a tracking link. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Warm up the failed TryFindClass fallback path before measuring global reference counts so the assertion does not include one-time runtime caches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
changed the title
Android's global reference count is process-wide, so exact equality can fail when unrelated runtime or test infrastructure work allocates persistent refs during the assertion. Repeat failed TryFindClass calls and allow bounded Android noise so per-call leaks are still amplified. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Disable the flaky UTF-8 TryFindClass gref assertion again while the tracking issue investigates a more reliable way to test JNI reference leaks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
changed the title
simonrozsival
added
the
ready-to-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily ignores
TryFindClass_Utf8_DoesNotLeakGlobalRefs, which is failing frequently in CI.Tracking issue: #12031
Current hypothesis: this test is not a reliable exact leak assertion on Android because the runtime gref count is process-wide. NUnit test execution is serialized (
NumberOfTestWorkers=0), but unrelated runtime/test-infrastructure work can still allocate persistent grefs on other threads while the assertion is running. The linked issue tracks finding a better way to test memory/reference leaks.Example failure: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1498907&view=results