Clean Code for ui/org.eclipse.pde.launching

[eclipse-pde-bot]

The following cleanups were applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Remove unused private constructors
• Remove unused private fields
• Remove unused private methods
• Remove unused private types
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

The following Manifest cleanups where applied:

• Calculate 'uses' directive for public packages
• Remove unused dependencies

[eclipse-pde-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From f5fe509caad8e204c5bc7e4ed77270ceafb355c3 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Fri, 6 Mar 2026 04:15:07 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF
index c78c865ee9..d899c71d79 100644
--- a/ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.launching;singleton:=true
-Bundle-Version: 3.13.600.qualifier
+Bundle-Version: 3.13.700.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Bundle-Vendor: %provider-name
 Require-Bundle: org.eclipse.jdt.junit.core;bundle-version="[3.6.0,4.0.0)",
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 36 files   -    90   36 suites   - 90   19s ⏱️ - 34m 20s
 26 tests  - 3 484   26 ✅  - 3 430  0 💤  -  54  0 ❌ ±0 
135 runs   - 9 198  135 ✅  - 9 068  0 💤  - 130  0 ❌ ±0 

Results for commit 71338ac. ± Comparison against base commit af2b487.

This pull request removes 3484 tests.

org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractCommandWithCategory
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractHandlerWithCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractHandlerWithoutCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractPlaceHolder
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractResolveCommandsWithTwoHandledItemsWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractResolveCommandsWithTwoHandlerWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractSinglePart
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoHandlerWithDifferentCommands
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoHandlerWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoPartsSameLocation
…

♻️ This comment has been updated with latest results.

[HannesWell]

@laeubi this also causes compiler errors:

Error:  Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:5.0.2:compile (default-compile) on project org.eclipse.pde.launching: Compilation failure: Compilation failure: 
Error:  /home/runner/work/eclipse.pde/eclipse.pde/ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/JUnitLaunchConfigurationDelegate.java:[1] 
Error:  	/*******************************************************************************
Error:  	^
Error:  The type aQute.bnd.osgi.Analyzer cannot be resolved. It is indirectly referenced from required type org.eclipse.pde.internal.core.bnd.PdeProjectAnalyzer
Error:  /home/runner/work/eclipse.pde/eclipse.pde/ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/JUnitLaunchConfigurationDelegate.java:[235] 
Error:  	try (PdeProjectAnalyzer analyzer = new PdeProjectAnalyzer(javaProject.getProject(), true)) {
Error:  	     ^^^^^^^^^^^^^^^^^^
Error:  The resource type PdeProjectAnalyzer does not implement java.lang.AutoCloseable
Error:  /home/runner/work/eclipse.pde/eclipse.pde/ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/JUnitLaunchConfigurationDelegate.java:[236] 
Error:  	analyzer.setImportPackage("*"); //$NON-NLS-1$
Error:  	^^^^^^^^
Error:  The type PdeProjectAnalyzer is not visible
Error:  /home/runner/work/eclipse.pde/eclipse.pde/ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/JUnitLaunchConfigurationDelegate.java:[238] 
Error:  	analyzer.setBundleSymbolicName(bsn);
Error:  	^^^^^^^^
Error:  The type PdeProjectAnalyzer is not visible
Error:  /home/runner/work/eclipse.pde/eclipse.pde/ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/JUnitLaunchConfigurationDelegate.java:[239] 
Error:  	analyzer.set(Constants.FRAGMENT_HOST, testPlugin.getId());
Error:  	^^^^^^^^
Error:  The type PdeProjectAnalyzer is not visible
Error:  /home/runner/work/eclipse.pde/eclipse.pde/ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/JUnitLaunchConfigurationDelegate.java:[240] 
Error:  	analyzer.set(Constants.BUNDLE_ACTIVATIONPOLICY, Constants.ACTIVATION_LAZY);
Error:  	^^^^^^^^
Error:  The type PdeProjectAnalyzer is not visible
Error:  /home/runner/work/eclipse.pde/eclipse.pde/ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/JUnitLaunchConfigurationDelegate.java:[241] 
Error:  	Manifest calcManifest = analyzer.calcManifest();
Error:  	                        ^^^^^^^^
Error:  The type PdeProjectAnalyzer is not visible
Error: [ERROR] 7 problems (7 errors)