-
Notifications
You must be signed in to change notification settings - Fork 5
feat: extract build infrastructure into standalone scripts #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wdconinc
wants to merge
41
commits into
master
Choose a base branch
from
copilot/extract-build-scripts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+853
−526
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
564518d
feat: extract build infrastructure into standalone scripts
wdconinc 03beded
chore: chmod u+x build-eic.sh build-base.sh
plexoos 0855275
Add ghcr.io/eic/buildcache as default cache-from
wdconinc 2a44103
More pipefail
wdconinc 6654d12
fix: apk add bash
wdconinc a40a59c
ci(github): rewrite build jobs to call build-base.sh and build-eic.sh
wdconinc 289505d
refactor: unify push-by-digest output for all CI modes
wdconinc 2e625c6
build: default JOBS to $(nproc) instead of hardcoded 4
wdconinc 686742e
build(eic): drop unused spack version file sources
wdconinc 9481b77
build scripts: harmonize github/gitlab by normalizing CI_REGISTRY_PREFIX
wdconinc bbc86a0
ci: add pre-commit shellcheck hook for root-level shell scripts
wdconinc 38d707d
fix: docs: --jobs default to $(nproc)
wdconinc baa3daa
docs: --jobs default nproc
wdconinc 604ce7b
fix: preserve arch/vN suffix
wdconinc 0e64026
docs: default base is now debian:stable-slim
wdconinc 074ea00
docs: clarify argument and env var mismatch allowed
wdconinc c859cf1
fix: strip \r from GITHUB_REF_POINT_SLUG/GITHUB_BASE_REF_SLUG
wdconinc 4c12424
refactor: replace github-slug-action with inline slugify helper
wdconinc e0f2a6a
fix: strip CRLF line endings that embedded \r into ARCH variable
wdconinc 0e2c14f
fix: remove non-existent tag extraction from image@digest files
wdconinc c355192
fix: fix set up QEMU job step
wdconinc f8b57d9
fix: use getconf _NPROCESSORS_ONLN instead of nproc
wdconinc c7e09ab
fix: add mirrors.yaml to .gitignore to prevent secrets upload
wdconinc c061a72
feat: support -h/--help
wdconinc 91d3197
fix: update default tag handling to avoid accidental misuse
wdconinc fa1b268
feat: move gitlab ci pipeline to separate manifest merging job
wdconinc 0b5eb18
docs: fix stale BASE_IMAGE default (amd64/debian:stable-slim → debian…
wdconinc 2b58860
fix: use repo default branch for cache key fallback on push events
wdconinc 59c3c8e
fix: escape sed replacements and use temp file for mirrors.yaml
wdconinc 261f059
fix: mention both base images in local-fallback message
wdconinc d97587b
fix: mark registry credential secrets as required=false in Dockerfile
wdconinc f7ee567
fix: apk add coreutils
wdconinc 58475aa
fix(docs): build-eic --jobs: default: nproc
wdconinc ad86804
fix: build-*.sh: cd "${SCRIPT_DIR}"
wdconinc 1f3db00
fix(docs): consistentify
wdconinc 8687d48
build-eic: support comma-separated --build-type (default,nightly) (#252)
wdconinc 2c875ce
fix: mv {. => scripts}/build-{base,eic}.sh
wdconinc 4d4b2d4
fix: address reviewer comments
wdconinc 51f4aea
fix: restore check_image_size
wdconinc 5f3c569
fix: docs
wdconinc 2404641
fix: run npsim and eicrecon jobs in default container
wdconinc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Enforce LF line endings for all text files tracked in this repository. | ||
| # This prevents Windows editors from introducing CRLF endings in shell scripts, | ||
| # which causes bash to embed '\r' into variable values (e.g. ARCH=$(cmd)\r). | ||
| * text=auto eol=lf | ||
|
|
||
| # Explicitly mark binary files so they are never munged | ||
| *.png binary | ||
| *.jpg binary | ||
| *.ico binary |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # build-*.sh products | ||
| mirrors.yaml | ||
|
|
||
| # install.sh products | ||
| eic-shell | ||
| local/ | ||
|
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.