feat: dd4hep +g4hepem#315
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned eic/eic-spack revision used by the container build so the environment can pick up the DD4hep G4HepEm plugin patch (without enabling it by default in npsim, per the PR description).
Changes:
- Bump
EICSPACK_VERSIONto a newer commit SHA ineic-spack.sh.
wdconinc
moved this to Needs Review
in ePIC Review Board (auto-populated; changes will be discarded)
auto-merge was automatically disabled
June 20, 2026 23:16
Pull request was closed
wdconinc
changed the title
veprbl
reviewed
Jun 22, 2026
wdconinc
moved this from Needs Review
to In Review
in ePIC Review Board (auto-populated; changes will be discarded)
veprbl
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR enables the DD4hep's G4HepEm plugin, but in contrast to #308 it does not enable it by default in npsim. That shifts the testing back to the npsim PR.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply