Fixed Defaults for Holo. Shader's Parameters#1
Open
Bsting118 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon using the original shader on one of my JSON object models, a simple ceiling light whose geometry requires both sides of its faces to be shaded, the result was either the inner face being omitted from the shader by default or the overall shader being too bright when specifying the
(side: THREE.DoubleSide)parameter.The fix to this was revising the default values assigned to each of the shader's parameters, most notably the
blendingparameter's following code: fromthis.blending = (parameters.blendMode !== undefined) ? parameters.blendMode : AdditiveBlending;tothis.blending = (parameters.blendMode !== undefined) ? parameters.blendMode : NormalBlending;.To visualize this fix, see below screenshots of the BEFORE...:
Inner face of ceiling lamp being omitted from the shader --
Overall shader being too bright when using
(side: THREE.DoubleSide)innew HolographicMaterial( )constructor --...And the AFTER (with the fixes in this Pull-Request):
Result of final fixes applied in this PR, given the code,
const holoMaterial = new HolographicMaterial({hologramColor: '#ed3434', depthTest: true, enableBlinking: false, side:THREE.DoubleSide});--