Tentative fix for invalid rewrite of negated BDD in map_update_put_domains#15510
Draft
lukaszsamson wants to merge 1 commit into
Draft
Tentative fix for invalid rewrite of negated BDD in map_update_put_domains#15510lukaszsamson wants to merge 1 commit into
lukaszsamson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as draft
First cond case handles pure positive disjunction where bdd_map is exact. Second handles noop put when
force? = falseand put domain is not in any of the leaves). Third one handles everything else by over approximating (applying put to positive DNF and dropping the negations). This is a compromise that widens the result set. A precise version would require a bigger change (computing the image of difference)Branch 3 converts to DNF and rebuilds via
map_union. Branches 1 and 2 add two traversalsAssisted-by: Claude Opus 4.8 & GPT 5.5
Fixes #15509