Skip to content

Respect image's orientation #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattfbacon wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Respect image's orientation #8240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion crates/egui_extras/src/image.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,23 @@ use egui::SizeHint;
/// On invalid image or unsupported image format.
#[cfg(feature = "image")]
pub fn load_image_bytes(image_bytes: &[u8]) -> Result<egui::ColorImage, egui::load::LoadError> {
fn load_image_with_orientation(image_bytes: &[u8]) -> image::ImageResult<image::DynamicImage> {
use std::io::Cursor;

use image::{DynamicImage, ImageDecoder, ImageReader};

let format = image::guess_format(image_bytes)?;
let reader = Cursor::new(image_bytes);
let reader = ImageReader::with_format(reader, format);
let mut decoder = reader.into_decoder()?;
let orientation = ImageDecoder::orientation(&mut decoder)?;
let mut image = DynamicImage::from_decoder(decoder)?;
image.apply_orientation(orientation);
Ok(image)
}

profiling::function_scope!();
let image = image::load_from_memory(image_bytes).map_err(|err| match err {
let image = load_image_with_orientation(image_bytes).map_err(|err| match err {
image::ImageError::Unsupported(err) => match err.kind() {
image::error::UnsupportedErrorKind::Format(format) => {
egui::load::LoadError::FormatNotSupported {
Expand Down
Loading