Fix vulnbox build potentially failing on image pull#108
Open
Janrupf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vulnbox builds could fail if the following docker compose config snippets were used:
The
docker compose pulltried to pull themediocre-simh:latesttag from the official docker repo, failed, and then short circuited and failed the entire build. However, that image is buildable, and thus should not crash the vulnbox packing.Docker image building now Ignores all buildables images, I assume for enowars this will not cause any unexpected behavior (unless someone pushes their enowars image to the docker hub and expects it to be downloaded, and even then packing should succeed due to the build command [1]).
[1]: If someone pushes their enowars docker image to the docker hub we have a bigger problem anyway