Skip to content

Fix vulnbox build potentially failing on image pull#108

Open
Janrupf wants to merge 1 commit into
enowars:mainfrom
Janrupf:main
Open

Fix vulnbox build potentially failing on image pull#108
Janrupf wants to merge 1 commit into
enowars:mainfrom
Janrupf:main

Conversation

@Janrupf

@Janrupf Janrupf commented Jun 30, 2026

Copy link
Copy Markdown

The vulnbox builds could fail if the following docker compose config snippets were used:

build: ./deploy
image: mediocre-simh:latest

The docker compose pull tried to pull the mediocre-simh:latest tag from the official docker repo, failed, and then short circuited and failed the entire build. However, that image is buildable, and thus should not crash the vulnbox packing.

Docker image building now Ignores all buildables images, I assume for enowars this will not cause any unexpected behavior (unless someone pushes their enowars image to the docker hub and expects it to be downloaded, and even then packing should succeed due to the build command [1]).


[1]: If someone pushes their enowars docker image to the docker hub we have a bigger problem anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant