[CVPN-2539] remove IP addresses on TUN interface drop#456
Draft
xv-piotr-haber wants to merge 1 commit into
Draft
[CVPN-2539] remove IP addresses on TUN interface drop#456xv-piotr-haber wants to merge 1 commit into
xv-piotr-haber wants to merge 1 commit into
Conversation
Tun-rs tries to open existing TUN interface with specified name if it already exists. But when adding IP address to it an error may occur if that address is already assigned to the interface. To allow lightway to re-use existing TUN interface remove all addresses on close, so when restarted lightway can assign them successfully again.
|
Code coverage summary for 1be766c: ✅ Region coverage 68% passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tun-rs tries to open existing TUN interface with specified name if it already exists. But when adding IP address to it an error may occur if that address is already assigned to the interface. To allow lightway to re-use existing TUN interface remove all addresses on close, so when restarted lightway can assign them successfully again.
The error only occurs on windows.
Motivation and Context
We want to be able to control TUN interface life cycle outside of lightway.
How Has This Been Tested?
Created WinTUN interface in external program and started lightway to verify interface is used and usable.
Tested repeated use of the same interface by new lightway instances.
Types of changes
Checklist:
main