feat: warn on unknown config keys#1613
Open
syu-toutousai wants to merge 1 commit into
Open
Conversation
floatpanebot
previously requested changes
Jun 23, 2026
floatpanebot
left a comment
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Hi @syu-toutousai! Please fix the following issues with your PR:
- Title: Does not follow conventional commits (e.g.,
feat: added something,fix(core): resolved crash). - Title: Is too long (41 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
Member
|
AI |
floatpanebot
previously requested changes
Jun 23, 2026
floatpanebot
left a comment
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Hi @andrinoff! Please fix the following issues with your PR:
- Title: Does not follow conventional commits (e.g.,
feat: added something,fix(core): resolved crash). - Title: Is too long (41 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
syu-toutousai
changed the title
floatpanebot
dismissed stale reviews from themself
Formatting issues have been resolved. Thank you!
Author
|
Hi @andrinoff — thanks for taking a look. Happy to explain the implementation or make any changes you'd like to see. The approach uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Emit a warning at startup when the config file contains keys that the application does not recognize.
warnUnknownConfigKeysfunction that decodes top-level JSON keys and logs warnings for unknown onesjson.RawMessageto keep startup overhead negligibleWhy?
Typos or leftover/stale config keys currently fail silently. Surfacing them at startup helps users catch mistakes before wasting time debugging unexpected behavior.