testsuite: add missing FLUX_TESTS_LOGFILE support#7540
Merged
Conversation
Problem: Many sharness tests that do not call test_under_flux do not create a debug output file in <test_name>.output because they do not explicitly support appending --logfile to sharness arguments when FLUX_TESTS_LOGFILE is set in the environment. Support FLUX_TESTS_LOGFILE where necessary across all sharness tests.
Contributor
Author
|
Thanks! I'll set MWP. |
Contributor
Merge Queue Status
This pull request spent 10 seconds in the queue, including 1 second running CI. Required conditions to merge
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7540 +/- ##
=======================================
Coverage 83.78% 83.79%
=======================================
Files 569 569
Lines 95496 95496
=======================================
+ Hits 80014 80021 +7
+ Misses 15482 15475 -7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Many sharness tests that do not call test_under_flux do not create a debug output file in <test_name>.output because they do not explicitly support appending --logfile to sharness arguments when FLUX_TESTS_LOGFILE is set in the environment.
Support FLUX_TESTS_LOGFILE where necessary across all sharness tests.
Note: in #7538 a test in
t2219-job-manager-restart.tfailed, but we don't have the detailed logs because of this issue. This PR should fix that for this test and others.