Add categories to source controller CRDs#2086
Open
shruthihub wants to merge 3 commits into
Open
Conversation
matheuscscp
reviewed
Jun 20, 2026
matheuscscp
left a comment
matheuscscp
left a comment
Member
There was a problem hiding this comment.
Please undo the changes in non-v1 files.
Also, please add categories to Bucket and ExternalArtifact.
Also, please add the category all to all CRDs.
1 task
shruthihub
force-pushed
the
add-crd-categories
branch
from
5062788 to
9677b3a
Compare
Signed-off-by: kavirakesh14 <kavirakesh007@gmail.com>
shruthihub
force-pushed
the
add-crd-categories
branch
from
9677b3a to
488455a
Compare
Author
|
Thanks for the review. I've updated the PR to:
The CRDs have been regenerated accordingly. |
|
Hey @shruthihub Thanks for amazing contribution 🎉. please always run this command locally before raising pull request |
Signed-off-by: kavirakesh14 <kavirakesh007@gmail.com>
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
approved these changes
Jun 21, 2026
matheuscscp
left a comment
matheuscscp
left a comment
Member
There was a problem hiding this comment.
LGTM! 🚀
Looks like the +kubebuilder:resource marker was causing the old versions to influence the generated CRDs. I removed them and then all CRDs are now correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.