feat(tasks): add titlebar context menu#2772
Conversation
Greptile SummaryThis PR adds a right-click context menu to the task name in the task titlebar, surfacing two actions: copying the git branch name to the clipboard and opening the rename-task modal.
Confidence Score: 4/5Safe to merge — the change is well-scoped and the new context menu integrates cleanly alongside the existing Popover without interaction conflicts. The implementation is straightforward: two new menu items, proper async error handling, and a correct disabled state when no branch name is available. The only notable concern is the "Copy" label being ambiguous about what it copies, which could confuse users who right-click expecting to copy the task name displayed beneath the cursor. apps/emdash-desktop/src/renderer/features/tasks/task-titlebar.tsx — specifically the "Copy" context menu item label.
|
| Filename | Overview |
|---|---|
| apps/emdash-desktop/src/renderer/features/tasks/task-titlebar.tsx | Adds a right-click context menu to the task name in the titlebar with "Copy" (branch name) and "Rename" actions; the "Copy" item label is ambiguous given its position on the task name element. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/emdash-desktop/src/renderer/features/tasks/task-titlebar.tsx:198-199
**Ambiguous "Copy" label**
The menu item is labeled "Copy" but it copies the branch name, not the task name. Since the context menu is triggered from the task name element in the titlebar, users are very likely to expect "Copy" to copy the task name. Labeling it "Copy branch name" removes the ambiguity and avoids surprising behavior when `branchName` happens to differ significantly from the display name.
Reviews (1): Last reviewed commit: "feat(tasks): add titlebar context menu" | Re-trigger Greptile
|
I think this greptile comment is valid: |
Description
Screenshot/Recording (if applicable)
https://cap.link/214h9gmyzfh5vnx
Checklist
messages and, when possible, the PR title